Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Update hint message #12976

Merged
merged 4 commits into from
Aug 20, 2020

Conversation

PhoebeHui
Copy link
Contributor

Fixes #4749 and #10910

I didn't find the message for '.\vcpkg edit' which mentioned in issue #10910, it should be removed.

@PhoebeHui PhoebeHui added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team. labels Aug 18, 2020
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 18, 2020
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Will merge as soon as CI passes.

@JackBoosY JackBoosY added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Aug 19, 2020
@BillyONeal BillyONeal merged commit 680b292 into microsoft:master Aug 20, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
@PhoebeHui PhoebeHui deleted the dev/Phoebe/fixhintmessage branch October 22, 2020 08:15
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message to re-bootstrap vcpkg does not take host platform into account
4 participants