Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wt] Update to 4.4.0 #13005

Merged
merged 3 commits into from
Aug 21, 2020
Merged

[wt] Update to 4.4.0 #13005

merged 3 commits into from
Aug 21, 2020

Conversation

RockinRoel
Copy link
Contributor

@RockinRoel RockinRoel commented Aug 19, 2020

  • Removed obsolete Boost disable autolink patch (Wt no longer uses
    autolinking for recent Boost versions)
  • Removed obsolete OpenSSL patch (Wt switched to using the
    standard CMake FindOpenSSL module)
  • Listed all Boost dependencies based on which Boost headers Wt uses
  • Added optional GraphicsMagick dependency for WRasterImage on non-Windows
  • Added libharu dependency for WPdfImage
  • Limited Pango dependency to only non-Windows (on Windows DirectWrite
    is used), added a tweak so it finds Harfbuzz and added it to
    Build-Depends
  • Added feature switches for Dbo and its backends: Sqlite3, PostgreSQL,
    and MS SQL Server, and for OpenSSL
  • Explicitly disabled BUILD_TESTS, ENABLE_FIREBIRD, and ENABLE_QT5
  • Reenabled libwttest

@ghost
Copy link

ghost commented Aug 19, 2020

CLA assistant check
All CLA requirements met.

@RockinRoel
Copy link
Contributor Author

Notes:

  • I tried to add support for wtdbomysql by adding a libmariadb dependency, but I'm currently running into some issues getting Wt to use it. This may need some upstream changes.
  • There's maybe some dependencies that could be behind feature flags, too. It seemed logical to have feature flags for different Dbo backends, and for OpenSSL. Maybe it also makes sense to do the same for:
    • WRasterImage (needs GraphicsMagick on Linux, can use Direct2D on Windows)
    • advanced font support (needs Pango on Linux, can use DirectWrite on Windows)
    • zlib (compression support in wthttp)
    • WPdfImage (needs libharu)
  • I ran into issues building the unixodbc dependency on Fedora, so the sqlserver feature wasn't tested on Linux. I know that normally this works when using the operating system's unixodbc.

@RockinRoel RockinRoel force-pushed the wt-4.4.0 branch 2 times, most recently from 1fcc943 to 65c995e Compare August 19, 2020 17:20
@RockinRoel
Copy link
Contributor Author

I had initially added graphicsmagick as a dependency on Linux, and -DWT_WRASTERIMAGE_IMPLEMENTATION=GraphicsMagick. I thought this was working, but it actually had used my system's GraphicsMagick. I could get it to link properly with the one from vcpkg but it would cause linking difficulty downstream, so I removed it.

@RockinRoel
Copy link
Contributor Author

I added GraphicsMagick support as an optional feature, using unofficial::graphicsmagick::graphicsmagick.

 - Removed obsolete Boost disable autolink patch (Wt no longer uses
   autolinking for recent Boost versions)
 - Removed obsolete OpenSSL patch (Wt switched to using the
   standard CMake FindOpenSSL module)
 - Listed all Boost dependencies based on which Boost headers Wt uses
 - Added optional GraphicsMagick dependency for WRasterImage on
   non-Windows
 - Added libharu dependency for WPdfImage
 - Limited Pango dependency to only non-Windows (on Windows DirectWrite
   is used), added a tweak so it finds Harfbuzz and added it to
   Build-Depends
 - Added feature switches for Dbo and its backends: Sqlite3, PostgreSQL,
   and MS SQL Server, and for OpenSSL
 - Explicitly disabled BUILD_TESTS, ENABLE_FIREBIRD, and ENABLE_QT5
 - Reenabled libwttest
@RockinRoel RockinRoel marked this pull request as ready for review August 19, 2020 21:36
@LilyWangL LilyWangL added the category:port-update The issue is with a library, which is requesting update new revision label Aug 20, 2020
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Aug 20, 2020
@BillyONeal BillyONeal merged commit 3fc65fa into microsoft:master Aug 21, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
@RockinRoel RockinRoel deleted the wt-4.4.0 branch December 15, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants