Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openmama] Feature use cmake for openmama #13034

Merged
merged 6 commits into from
Aug 21, 2020

Conversation

fquinner
Copy link
Contributor

Describe the pull request

  • What does your PR fix? Updates OpenMAMA port to use cmake rather than scons (its new preferred buildsystem)

  • Which triplets are supported/not supported? Have you updated the CI baseline? x86/x64-release/debug

  • Does your PR follow the maintainer guide? Yes

@PhoebeHui PhoebeHui changed the title Feature use cmake for openmama [openmama] Feature use cmake for openmama Aug 21, 2020
@PhoebeHui
Copy link
Contributor

@fquinner, thanks for the PR!

Could you update the Port-Version in CONTROL file?
From
Version: 6.3.0
To
Version: 6.3.0
Port-Version: 1

@PhoebeHui PhoebeHui added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Aug 21, 2020
@fquinner
Copy link
Contributor Author

@PhoebeHui Thanks for looking! Yes I just pushed in a commit to include that change, hopefully all is OK now!

@PhoebeHui
Copy link
Contributor

@fquinner, thanks for your updates!

I just noticed the following triplets disabled in CI testing, does them support now? if it supports, could you remove them from the ci.baseline file, if not, could you help add them to 'Supports' in CONTROL file?

In scripts/ci.baseline.txt file:
openmama:x64-windows=fail
openmama:x86-windows=fail
openmama:x64-linux=fail
openmama:x64-osx=fail

@fquinner
Copy link
Contributor Author

Thanks @PhoebeHui - pushed in some new changes for this to add Supports to CONTROL file and remove entries from ci baseline for failure exceptions that should now work.

@PhoebeHui
Copy link
Contributor

Could you also remove the following lines?

openmama:x64-linux=fail
openmama:x64-osx=fail

@fquinner
Copy link
Contributor Author

Ah yes of course with Supports that won't be required any more - will do.

@fquinner
Copy link
Contributor Author

@PhoebeHui ok that's updated now

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PhoebeHui PhoebeHui added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines and removed category:port-update The issue is with a library, which is requesting update new revision labels Aug 21, 2020
@BillyONeal BillyONeal merged commit fc7bab5 into microsoft:master Aug 21, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants