Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libusb] Add vcpkg-cmake-wrapper #13057

Merged
merged 3 commits into from
Aug 26, 2020
Merged

[libusb] Add vcpkg-cmake-wrapper #13057

merged 3 commits into from
Aug 26, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Aug 21, 2020 •
edited
Loading

Since libusb does not provide cmake files, add a vcpkg-cmake-wrapper to use this port more conveniently.
Also fix azure-kinect-sensor-sdk can't find libusb on Linux.

Related: #12995.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Aug 21, 2020
@JackBoosY JackBoosY removed the request for review from PhoebeHui August 21, 2020 09:47
PhoebeHui
PhoebeHui approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Aug 25, 2020
@BillyONeal BillyONeal merged commit 0522f98 into microsoft:master Aug 26, 2020
@JackBoosY JackBoosY deleted the dev/jack/add_libusb_warpper branch August 26, 2020 02:07
@JackBoosY JackBoosY mentioned this pull request Aug 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JackBoosY @PhoebeHui @BillyONeal