You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default timeout is 10s, and MSYS2 servers are rather slow. When additional being on a slow internet connection, installation of MSYS2 fails. Fix by disabling timeout.
we use the same scripts in the CI system, where a timeout is necessary to avoid a stalled machine waiting for nothing
Maybe increasing it might be better, than just removing it?
I agree, no timeout whatsoever is a problem but we can set a longer value than 10s... even if the tool itself can't do that the _execute_process call has TIMEOUT
As pacman only allows to disable the timeout (or use a custom command), I set a timeout via _execute_process as @BillyONeal suggested, and extended vcpkg_execute_required_process accordingly to pass a timeout forward to _execute_process.
Made the timeout in the last case (install the packages) in vcpkg_acquire_msys() configurable as someone may want to install many packages and thus needs a longer timeout.
PhoebeHui
changed the title
Disable timeout (default 10s) in vcpkg_acquire_msys
[vcpkg] Disable timeout (default 10s) in vcpkg_acquire_msys
Aug 28, 2020
category:tool-updateThe issue is with build tool or build script, which requires update or should be executed correctlyinfo:reviewedPull Request changes follow basic guidelines
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhoebeHui
added
the
category:tool-update
Default timeout is 10s, and MSYS2 servers are rather slow. When additional being on a slow internet connection, installation of MSYS2 fails. Fix by disabling timeout.