[vcpkg] Fix vcpkg_acquire_msys failing on path with spaces #13104
Conversation
Make sure to quote the KEYRING_PATH
|
Just saying: If your path has spaces not only msys install will fail but probably also |
PhoebeHui
added
the
category:tool-update
| @@ -107,15 +107,15 @@ function(vcpkg_acquire_msys PATH_TO_ROOT_OUT) | |||
| ) | |||
| # install the new keyring | |||
| _execute_process( | |||
| COMMAND ${PATH_TO_ROOT}/usr/bin/bash.exe --noprofile --norc -c "PATH=/usr/bin;pacman-key --verify ${KEYRING_SIG_PATH}" | |||
| COMMAND ${PATH_TO_ROOT}/usr/bin/bash.exe --noprofile --norc -c "PATH=/usr/bin;pacman-key --verify \"${KEYRING_SIG_PATH}\"" | |||
| WORKING_DIRECTORY ${TOOLPATH} | |||
There was a problem hiding this comment.
Stupid question: Does this WORKING_DIRECTORY also need quotes?
There was a problem hiding this comment.
From my testing only the KEYRING_SIG_PATH needed quotes since it's a command string passed to bash. The rest are handled by CMake.
|
@Neumann-A I tested this with fribidi which uses vcpkg_acquire_msys for meson. I didn't get any other errors so I assume it doesn't depend on configure/make. I realize that vcpkg on a path with spaces is a constant struggle, but I figure any fix is better than none. :) |
|
Thanks for your contribution! |
Describe the pull request
If vcpkg is installed on a path with spaces, packages that need to install MSYS2 fail due to unquoted paths in vcpkg_acquire_msys.
This adds the missing quotes where appropriate.
N/A
Yes