Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[caf] Update caf to 0.17.6 #13175

Merged
merged 7 commits into from
Aug 31, 2020
Merged

[caf] Update caf to 0.17.6 #13175

merged 7 commits into from
Aug 31, 2020

Conversation

rkesters
Copy link
Contributor

Update caf to 0.17.6

  • What does your PR fix? I did not create an issues, I just did the work of updating caf to the latest version.

  • Which triplets are supported/not supported? no change

  • Have you updated the CI baseline? no

  • Does your PR follow the maintainer guide? yes

@ghost
Copy link

ghost commented Aug 27, 2020

CLA assistant check
All CLA requirements met.

@rkesters
Copy link
Contributor Author

Can I get some help from a maintainer? The one job that is failing appears ti fail ob build tinyxml, which i did not change.

@PhoebeHui PhoebeHui added the category:port-update The issue is with a library, which is requesting update new revision label Aug 27, 2020
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see theat failure, it seems flaky issues, I have rerun the pipeline.

ports/caf/portfile.cmake Outdated Show resolved Hide resolved
@PhoebeHui PhoebeHui marked this pull request as ready for review August 27, 2020 10:32
@rkesters
Copy link
Contributor Author

rkesters commented Aug 27, 2020

@PhoebeHui do I need to do anything else to get this merged? If not when do you think it will be merged?

Thank you for your help.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Aug 28, 2020
@PhoebeHui
Copy link
Contributor

@BillyONeal, could you help merge this PR?

@PhoebeHui PhoebeHui changed the title Update caf to 0.17.6 [caf] Update caf to 0.17.6 Aug 28, 2020
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch file quesiton...

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good; just wanted to make sure you intended to remove it :). Thanks!

@rkesters
Copy link
Contributor Author

@PhoebeHui or @BillyONeal can one of you help the Azure Pipeline it appears to be hung up, been running for over a day.

@BillyONeal
Copy link
Member

It's not been over a day; I pushed a change 7 hours ago that reset it. You just got a little unlucky and there were like 3 PRs that each rebuilt the full tree in front of this one. We have 18 windows boxes in the fleet and they've been busy; rebuilding 1300+ ports takes awhile.

(Bottom 3 rows are the Linux, Windows, and Mac fleet respectively; the Windows fleet is much bigger because we test 6 triplets for it vs only 1 for the other 2 platforms
image
)

@PhoebeHui
Copy link
Contributor

The CI failed to download source before, passed after rerun.

@BillyONeal BillyONeal merged commit 5471b15 into microsoft:master Aug 31, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants