[vcpkg] Implement 'repository' tag for NuGet binary caching #13228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tag is required to correctly interface with GitHub Packages, because GHP shares a single remote for the entire organization and uses the repository field to associate a package with a particular repository. This tag will be automatically generated if the default GitHub Actions environment variables are present (GITHUB_XYZ) or if the user defines VCPKG_NUGET_REPOSITORY.
PhoebeHui
added
the
category:vcpkg-feature
BillyONeal
approved these changes
Sep 1, 2020
BillyONeal
reviewed
Sep 1, 2020
| @@ -973,9 +973,27 @@ std::string vcpkg::reformat_version(const std::string& version, const std::strin | |||
| return Strings::concat("0.0.0-", abi_tag); | |||
| } | |||
|
|
|||
| details::NuGetRepoInfo details::get_nuget_repo_info_from_env() | |||
There was a problem hiding this comment.
I'm not sure how I feel about adding additional places we acquire vcpkg-specific environment settings other than VcpkgCmdArguments::imbue_from_environment. (This comment applies only to VCPKG_NUGET_REPOSITORY, not the others which one might consider 'well known', although in general I would like to see us get away from mixing the acquisition of information from the system and the act of using that information as that makes testing difficult)
No concrete change requested right now, and this does clearly suck that acquisition into a separate function which is good, but something to consider.
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…t#13228) This tag is required to correctly interface with GitHub Packages, because GHP shares a single remote for the entire organization and uses the repository field to associate a package with a particular repository. This tag will be automatically generated if the default GitHub Actions environment variables are present (GITHUB_XYZ) or if the user defines VCPKG_NUGET_REPOSITORY. Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tag is required to correctly interface with GitHub Packages, because GHP shares a single remote for the entire organization and uses the repository field to associate a package with a particular repository.
This tag will be automatically generated if the default GitHub Actions environment variables are present (GITHUB_XYZ) or if the user defines VCPKG_NUGET_REPOSITORY.