[blaze][ceres][clapack][geogram][lapack][lapack-reference][opencv4][selene] Fix deps issues #13229
Conversation
ras0219
force-pushed
the
dev/roschuma/lapack
branch
from
e53a6c0
to
9297195
Compare
…issues As part of a full rebuild in microsoft#13019, several transitive rebuild issues were found. 1) selene was dynamically detecting the presence of OpenCV, which was not on its dependency list. 2) The dynamic OpenCV was using `find_package()` instead of `find_dependency()` 3) The dynamic OpenCV was always finding all dependencies instead of just those that were used during build. 4) CMake's FindHDF5 module requires C language support 5) ceres was passing `REQUIRED` into find_dependency (not needed -- find_dependency implies REQUIRED) 6) FindLAPACK.cmake was sometimes provided by the meta-port lapack, sometimes by the dependency lapack-reference/clapack 7) The lapack-reference vcpkg-cmake-wrapper was directly including the FindLAPACK, which doesn't respect variables such as QUIET and REQUIRED Interestingly, the particular issue required a cascade of failures to occur to actually cause a build failure; almost any of these fixes would independently fix the build.
ras0219
force-pushed
the
dev/roschuma/lapack
branch
from
9297195
to
22935b5
Compare
|
The same cleaner solution for find_dependencies can be applied to opencv2/3. I used find_package and QUIET to “hack” the system, but it is not as robust as this. |
|
On uwp, the dependencies are disabled: This per-platform logic is already implemented above in the |
NancyLi1013
added
category:port-feature
|
Hi there @ras0219 :) zxing-cpp failed on x64-windows-static due to the default build-depends not having protobuf: BillyONeal@f9cc362 |
|
(I have those changes prepared in https://github.com/BillyONeal/vcpkg/commits/robert_review_fix if you want to use it as a base) |
|
@ras0219 and I talked about this stuff out of band. |
|
I'm looking into the dbow2 failure (looks like the transitive dependency through opencv isn't being handled appropriately) From dbow2:
|
…into dev/roschuma/lapack
…roschuma/lapack
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
added
the
requires:all-feature-testing
…ich is not available in UWP.
…not supported there.
BillyONeal
changed the title
|
Submitted the Blaze patch upstream: https://bitbucket.org/blaze-lib/blaze/pull-requests/44/fix-inability-to-build-blaze-on-some |
BillyONeal
changed the title
|
@dan-shaw Good point. |
|
Thanks for your contribution! |
As part of a full rebuild in #13019, several transitive rebuild issues were found.
find_package()instead offind_dependency()REQUIREDinto find_dependency (not needed -- find_dependency implies REQUIRED)Interestingly, the particular issue required a cascade of failures to occur to actually cause a build failure; almost any of these fixes would independently fix the build.