-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg|toolchain] add VCPKG_OVERLAY_(PORTS|TRIPLETS) to the toolchain #13240
[vcpkg|toolchain] add VCPKG_OVERLAY_(PORTS|TRIPLETS) to the toolchain #13240
Conversation
We hope to address this via settings in the manifest file; adding these settings via cmake is problematic because they won't be present when you run other commands like |
this does not belong there ..... users should always be free to supply their own version of dependencies and have it not hardcoded! The same goes for toolchain/triplet settings.
the manifest installed dir does not directly belong to the user but to the project and is put into |
@Neumann-A the plan was to put it in the |
@strega-nil: As far as I understand |
@Neumann-A the |
In that case it does not belong into the |
fair enough, I guess. |
Hrm, I've changed my opinion on this after some cajoling from Billy. I think this feature should be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one minor suggestion (which doesn't need to be taken, I just think it might be a nicer design as a whole)
So people can add the overlays from cmake instead of modifying the environment