Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[powershell] Update to 7.0.3 #13267

Merged
merged 2 commits into from
Sep 5, 2020
Merged

[powershell] Update to 7.0.3 #13267

merged 2 commits into from
Sep 5, 2020

Conversation

JackBoosY
Copy link
Contributor

Update Powershell to 7.0.3 to solve the crash issue when calling the script applocal.ps1 to find dependencies.

Fixes #12849.

@JackBoosY JackBoosY added info:internal This PR or Issue was filed by the vcpkg team. category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Sep 1, 2020
@JackBoosY JackBoosY mentioned this pull request Sep 1, 2020
Closed
cenit
cenit reviewed Sep 1, 2020
View reviewed changes
ports/protobuf/CONTROL Outdated Show resolved Hide resolved
JackBoosY
JackBoosY commented Sep 1, 2020
View reviewed changes
ports/protobuf/CONTROL Outdated Show resolved Hide resolved
ras0219
ras0219 approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@ras0219 ras0219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I would revert the changes to brotli and protobuf.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Sep 3, 2020
@BillyONeal
Copy link
Member

BillyONeal commented Sep 3, 2020 •
edited
Loading

I agree with @ras0219 ; we shouldn't force vcpkg upgrade to reinstall those ports over this. Rebased on master without those edits and will merge once CI comes back. Thanks for your contribution!

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal BillyONeal merged commit 9ae0b0d into microsoft:master Sep 5, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@JackBoosY JackBoosY deleted the dev/jack/12849 branch September 7, 2020 02:30
@BillyONeal BillyONeal mentioned this pull request Sep 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cenit cenit cenit left review comments

@ras0219 ras0219 ras0219 approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vcpkg_copy_tool_dependency] Call powershell function failed
5 participants
@JackBoosY @BillyONeal @ras0219 @cenit @PhoebeHui