[vcpkg_acquire_msys.cmake] Add gettext tool #13297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
added
the
category:tool-update
ras0219
suggested changes
Sep 2, 2020
1. Added dependencies to gettext-0.19.8.1-1-x86_64.pkg.tar.xz
of libintl libgettextpo libasprintf
2. Added dependency download for libgettextpo-0.19.8.1-1-x86_64.pkg.tar.xz
3. Added dependency download for libasprintf-0.19.8.1-1-x86_64.pkg.tar.xz
4. Put downloads in reverse dependcy order - seems it is called
topological order now
ras0219
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Thanks for making the fixes and sorry for the confusing term! This is exactly what I meant :)
The reason we want to split up the msys2 directories is to avoid one port having a "hidden" dependency on another -- for example, when A installs gettext we don't want it to silently also be provided to B.
|
Thanks for your contribution! |
You are most welcome @BillyONeal. Have a wonderful weekend... Thank you for all the hard work. 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
[vcpkg_acquire_msys.cmake] Add gettext tool needed by libpq
What does your PR fix? Fixes [vcpkg_acquire_msys.cmake] missing download of gettext #13291 [vcpkg_acquire_msys.cmake] missing download of gettext
Which triplets are supported/not supported? Not Applicable
Have you updated the CI baseline? Not Applicable
Does your PR follow the maintainer guide? Yes