Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[d3dx12] Add new port #13360

Merged
merged 6 commits into from
Sep 11, 2020
Merged

[d3dx12] Add new port #13360

merged 6 commits into from
Sep 11, 2020

Conversation

mteterel
Copy link
Contributor

@mteterel mteterel commented Sep 4, 2020

@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 7, 2020
NancyLi1013
NancyLi1013 suggested changes Sep 7, 2020
View reviewed changes
ports/d3dx12/portfile.cmake Outdated Show resolved Hide resolved
ports/d3dx12/vcpkg.json Outdated Show resolved Hide resolved
ports/d3dx12/portfile.cmake Show resolved Hide resolved
mteterel and others added 2 commits September 7, 2020 09:55
@mteterel @NancyLi1013
Apply suggestions from code review
46518be 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@mteterel
Update portfile.cmake
9eec696 
Use the correct d3dx12.h that does not require the very latest Windows SDK
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 8, 2020
ras0219-msft
ras0219-msft requested changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

LGTM once my comments are addressed.

ports/d3dx12/portfile.cmake Outdated Show resolved Hide resolved
ports/d3dx12/vcpkg.json Outdated Show resolved Hide resolved
@mteterel @ras0219-msft
Apply suggestions from code review
b2e6185 
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
@NancyLi1013
Copy link
Contributor

Also needs to update hash value.

CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:102 (message):

File does not have expected hash:

      File path: [ D:/downloads/temp/d3dx12.h ]
  Expected hash: [ 58a1f5060c82c2769987592d6f20d8c8d86032505740492b24f69c88b75f0814d3f18d5c3ae7c71c54bfe5eeb7f844ee623ce73376a676986db0643589aab62b ]
    Actual hash: [ 829b72ddf861652bd96518b7d54f7a103c95b4434ec022e1551fb085e4dfc8f804e01ccdb4677e3f64367553c56d35291b305e10c2ea6186ddadaaa071c6d7a2 ]

NancyLi1013
NancyLi1013 suggested changes Sep 11, 2020
View reviewed changes
ports/d3dx12/portfile.cmake Outdated Show resolved Hide resolved
@ras0219-msft ras0219-msft merged commit 0896bb8 into microsoft:master Sep 11, 2020
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mteterel @NancyLi1013 @ras0219-msft