Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libtorrent] Fix build on arm-linux community triplet #13375

Merged
merged 3 commits into from
Sep 10, 2020
Merged

[libtorrent] Fix build on arm-linux community triplet #13375

merged 3 commits into from
Sep 10, 2020

Conversation

FranciscoPombal
Copy link
Contributor

Tested on a Raspberry Pi 4 running the latest stable release of Raspbian/Raspberry PI OS (32-bit).

No additional features were tested, just the basic baseline package.

@FranciscoPombal
Copy link
Contributor Author

CI failures are unrelated.

@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 7, 2020
@NancyLi1013
Copy link
Contributor

Hi @FranciscoPombal
Thanks for this PR.
Have you tested if these features can work fine?

@FranciscoPombal @NancyLi1013
[libtorrent] Add Port-Version to CONTROL file
b1a04f5 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@FranciscoPombal
Copy link
Contributor Author

@NancyLi1013

Have you tested if these features can work fine?

I haven't tested any additional features, I fixed the baseline installation: vcpkg install libtorrent:arm-linux. In the future I will try out the features and submit follow-up PRs (or an issue report) if needed.

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 8, 2020
ras0219-msft
ras0219-msft requested changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once my suggestion is applied.

Thanks for the PR!

ports/libtorrent/CONTROL Outdated Show resolved Hide resolved
@FranciscoPombal @ras0219-msft
Add explicit dependeny on boost-pool for all triplets
6829cd6 
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
@ras0219-msft ras0219-msft merged commit 18ab4b7 into microsoft:master Sep 10, 2020
@ras0219-msft
Copy link
Contributor

Thanks again!

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Sep 10, 2020
@Jimmy-Hu
Merge pull request #322 from microsoft/master
b364ce6 
[libtorrent] Fix build on arm-linux community triplet (microsoft#13375)
@FranciscoPombal FranciscoPombal deleted the fix_libtorrent branch September 10, 2020 10:48
@FranciscoPombal FranciscoPombal mentioned this pull request Nov 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219 ras0219 ras0219 left review comments

@ras0219-msft ras0219-msft ras0219-msft requested changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FranciscoPombal @NancyLi1013 @ras0219-msft @ras0219