Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Add metrics for binarycaching feature #13486

Merged
merged 1 commit into from
Sep 14, 2020
Merged

[vcpkg] Add metrics for binarycaching feature #13486

merged 1 commit into from
Sep 14, 2020

Conversation

ras0219
Copy link
Contributor

@ras0219 ras0219 commented Sep 11, 2020

Adds boolean metrics for:

  • Defining VCPKG_DEFAULT_BINARY_CACHE
  • Defining VCPKG_BINARY_SOURCES
  • Defining VCPKG_NUGET_REPOSITORY
  • Defining GITHUB_REPOSITORY
  • Passing --x-write-nuget-packages-config
  • Passing --binarysource
  • Using clear as a binary source
  • Using nuget/nugetconfig as a binary source

@JackBoosY JackBoosY self-assigned this Sep 14, 2020
@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. labels Sep 14, 2020
@ras0219-msft ras0219-msft merged commit 11de106 into microsoft:master Sep 14, 2020
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@ras0219 @ras0219-msft
[vcpkg] Add metrics for binarycaching feature (microsoft#13486)
d83becd 
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-shaw dan-shaw dan-shaw approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ras0219 @dan-shaw @ras0219-msft @JackBoosY