[vcpkg, libpq] separate static and shared library installations #13491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebdron
force-pushed
the
libpq-static-shared
branch
from
bab2107
to
35f3e98
Compare
Neumann-A
reviewed
Sep 13, 2020
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
lebdron
force-pushed
the
libpq-static-shared
branch
from
35f3e98
to
a3c70f2
Compare
Signed-off-by: Andrei Lebedev <lebdron@gmail.com>
lebdron
force-pushed
the
libpq-static-shared
branch
from
a3c70f2
to
40172c3
Compare
LilyWangL
added
category:port-bug
LilyWangL
approved these changes
Sep 17, 2020
|
LGTM, thanks for the fix! |
|
This PR removed a lot of additional static libraries from libpq and is the reason that PR #13464 is now failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, libpq installation uses a top-level install target on non-Windows platforms. This results in having shared libraries installed even when all other libraries are static. Because CMake prefers shared libraries over static, builds result in shared library being linked, which does not correspond to triplet and other packages installations. Moreover, it causes packaging issues, since shared libraries have to be installed together with the binary.
This PR fixes the behavior by installing only libpq.a for the usual x64-linux triplet.