Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libsbml] New port for libsbml #13524

Merged
merged 13 commits into from
Oct 8, 2020
Merged

Conversation

CiaranWelsh
Copy link
Contributor

@CiaranWelsh CiaranWelsh commented Sep 14, 2020

Describe the pull request
This PR has a port for libsbml, a library for creating models in systems biology. This port was mostly built by JackBoosY (See issue #12558 on microsoft/vcpkg) with some minor additions for the libsbml "namespace" option.

Note, only the commits made in September bear any relevance, since they replaced earlier attempts at creating the lisbml port.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

I've tested on windows, ubuntu and mac. No I haven't updated the CI baseline.

To the best of my knowledge, yes.

Closes #12558

@ghost
Copy link

ghost commented Sep 14, 2020

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@Hoikas Hoikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13488 will soon be deprecating CONTROL files in favor of manifests. Perhaps this should use a manifest instead of a CONTROL file?

ports/libsbml/CONTROL Outdated Show resolved Hide resolved
ports/libsbml/CONTROL Show resolved Hide resolved
ports/libsbml/CONTROL Outdated Show resolved Hide resolved
ports/libsbml/portfile.cmake Outdated Show resolved Hide resolved
ports/libsbml/portfile.cmake Outdated Show resolved Hide resolved
ports/libsbml/portfile.cmake Outdated Show resolved Hide resolved
ports/libsbml/portfile.cmake Outdated Show resolved Hide resolved
ports/openblas/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY self-assigned this Sep 15, 2020
@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 25, 2020
ports/openblas/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Sep 30, 2020
@JackBoosY
Copy link
Contributor

JackBoosY commented Sep 30, 2020

Manually tested features on x86-windows.

@JackBoosY JackBoosY changed the title [libsbml] New port for libsbml. [libsbml] New port for libsbml Sep 30, 2020
@BillyONeal BillyONeal merged commit 34ea423 into microsoft:master Oct 8, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help resolving some issues adding a new port to a vcpkg clone.
4 participants