Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ninja] update to 1.10.1 #13562

Merged
merged 3 commits into from
Sep 24, 2020
Merged

[Ninja] update to 1.10.1 #13562

merged 3 commits into from
Sep 24, 2020

Conversation

Farwaykorse
Copy link
Contributor

Describe the pull request
This updates the Ninja build system from 1.10.0 to 1.10.1 (for Windows, Linux and MacOS).
release notes Ninja v1.10.1

@JackBoosY JackBoosY self-assigned this Sep 17, 2020
@JackBoosY JackBoosY added category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines labels Sep 17, 2020
@MVoz
Copy link
Contributor

MVoz commented Sep 17, 2020

vcpkg/scripts/cmake/vcpkg_find_acquire_program.cmake

Line 212 in bc21841

elseif(VAR MATCHES "NINJA")

@JackBoosY JackBoosY added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Sep 17, 2020
@Farwaykorse
Copy link
Contributor Author

Farwaykorse commented Sep 18, 2020 •
edited
Loading

Oh my! Putting the same thing in two locations ...
Thanks @voskrese for notifying me.

@Farwaykorse
Copy link
Contributor Author

I'm not sure why the CI on x86 failed. Downloading Ninja worked and it should have extracted, but CMake can't seem to find the executable.

All other CI-jobs got past this point without issues and various other jobs on Windows have already finished successfully.

@Farwaykorse Farwaykorse mentioned this pull request Sep 18, 2020
Closed
@JackBoosY
Copy link
Contributor

That's really weird and I can't repro it. @BillyONeal can you please take a look?

Thanks.

@BillyONeal
Copy link
Member

Looks like it was using an old azure-pipelines.yml; I pushed a merged with master and it seems happy now.

@BillyONeal
Copy link
Member

One other thing I'll note: asking GitHub to "rerun" doesn't trigger a "remerge" so it will only fix download failures. Pushing a merge with master is usually a better way to request a reattempt (unless your branch is already up to date of course)

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 23, 2020
@JackBoosY
Copy link
Contributor

LGTM.

@ras0219-msft
Copy link
Contributor

Thanks for the fixes everyone!

@ras0219-msft ras0219-msft merged commit 802c9c6 into microsoft:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vcpkg bootstrap fails on macOS 10.12 (cause: ninja update 1.10)
5 participants
@Farwaykorse @MVoz @JackBoosY @BillyONeal @ras0219-msft