-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kenlm] New Port #13692
[kenlm] New Port #13692
Conversation
We need to patch it's cmake files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure the headers are all installed.
Hi! You're welcome to drive by and patch my cmake. |
@JackBoosY @kpu thanks very much for both of your time working on this — where do we stand now? It looks like Port CI is failing on Linux... |
The linux build is failing on https://dev.azure.com/vcpkg/public/_build/results?buildId=43506&view=logs&j=d3670d0c-cc82-50c9-762c-eccde036829f&t=b5ba9409-7383-59d6-95ee-7a65895d5946&l=2182 complaining it is missing |
I think the only patch you still need is |
I'm OOF now, will continue this PR when I return. |
@kpu Tool |
|
@kpu, fine. So I'm done. Do you have any suggestions about this PR? |
Gentle bump, cc @kpu — are we ok to merge? |
Fix interpolate + Windows error desc Co-authored-by: Billy O'Neal <bion@microsoft.com>
@JackBoosY — are we ok to merge this? I think we need an accept from you. |
@BillyONeal Ping for merge this PR. |
Thanks for your contribution! |
Adds a port for the the KenLM library.
Things to note:
install
target, so files are manually globbed as needed.bin
tools as built by the library.Tested x64-linux.
Yes.
cc @kpu