[libdatachannel] Add new port #13704

Nemirtingas · 2020-09-24T07:59:42Z

Describe the pull request

What does your PR fix? Fixes [New Port Request] libdatachannel #13487, I'm also creating a port for libjuice.
Which triplets are supported/not supported?
I tested on lwindows x86, x64 static library, static CRT, it works.
I tested on linux, windows x86, x64 static library, it works.
I tested on linux, windows x86, x64 dynamic library, it doesn't work, I didn't figure out how to add usrsctp to the CMake path, find_package(usrsctp CONFIG) doesn't work.
Have you updated the CI baseline? No ?
Does your PR follow the maintainer guide?
The base CMake file builds 2 distinct libraries for static (which is not exported) and dynamic library. I've patched the CMakeLists.txt to build only the shared library and set it static if static library is picked in vcpkg.

This is my first port, please review carefully,

ports/libdatachannel/CONTROL

ports/libdatachannel/usage

ports/libdatachannel/portfile.cmake

Nemirtingas · 2020-09-25T10:30:19Z

I've modified the files the way you asked.

ras0219-msft · 2020-09-28T00:29:43Z

/azp run

azure-pipelines · 2020-09-28T00:29:55Z

Azure Pipelines successfully started running 1 pipeline(s).

…atachannel_port

Nemirtingas · 2020-10-01T05:36:57Z

I'm updating this lib to version 0.9.2. It needs an updated usrsctp port.
Also the usrsctp port doesn't export any library and there is no usage file.

…vcpkg into libdatachannel_port

JackBoosY · 2020-10-09T06:42:16Z

/azp run

azure-pipelines · 2020-10-09T06:42:22Z

No pipelines are associated with this pull request.

…atachannel_port

JackBoosY · 2020-10-10T06:27:01Z

@BillyONeal Our CI seems has problems, can you please take a look?

BillyONeal · 2020-10-12T17:38:45Z

@JackBoosY CI is failing because this port adds Build-Depends: libjuice but libjuice is not a port.

JackBoosY · 2020-10-13T06:28:23Z

We doesn't include port libjuice yet, please add it first.

Nemirtingas · 2020-10-13T06:29:29Z

We doesn't include port libjuice yet, please add it first.

Its in progress: #13703

Nemirtingas · 2020-10-23T10:21:07Z

libjuice has been merged, I'll work on this now.

Nemirtingas · 2020-10-23T14:04:34Z

Can someone look at the fail logs ? I've built the port on Windows and Linux, everything seems fine.

BillyONeal

@Nemirtingas Looks like there's a dependency you didn't declare (see below).

I also observe that you have an "srtp" feature but aren't responding to the feature in portfile.cmake at all.

 [1/2] cmd /c "cd .. && "D:/downloads/tools/cmake-3.18.4-windows/cmake-3.18.4-win32-x86/bin/cmake.exe" "D:/buildtrees/libdatachannel/src/v0.9.4-4b1512394f.clean" "-DNO_WEBSOCKET=OFF" "-DNO_EXAMPLES=ON" "-DNO_TESTS=ON" "-DCMAKE_SYSTEM_NAME=WindowsStore" "-DCMAKE_SYSTEM_VERSION=10.0" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/a/1/s/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=arm-uwp" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v142" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/a/1/s/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=arm" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/a/1/s" "-D_VCPKG_INSTALLED_DIR=D:/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-AARM" "-G" "Visual Studio 16 2019" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=D:/packages/libdatachannel_arm-uwp""
FAILED: ../CMakeCache.txt 
cmd /c "cd .. && "D:/downloads/tools/cmake-3.18.4-windows/cmake-3.18.4-win32-x86/bin/cmake.exe" "D:/buildtrees/libdatachannel/src/v0.9.4-4b1512394f.clean" "-DNO_WEBSOCKET=OFF" "-DNO_EXAMPLES=ON" "-DNO_TESTS=ON" "-DCMAKE_SYSTEM_NAME=WindowsStore" "-DCMAKE_SYSTEM_VERSION=10.0" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/a/1/s/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=arm-uwp" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v142" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/a/1/s/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=arm" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/a/1/s" "-D_VCPKG_INSTALLED_DIR=D:/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-AARM" "-G" "Visual Studio 16 2019" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=D:/packages/libdatachannel_arm-uwp""
-- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.
-- The CXX compiler identification is MSVC 19.27.29111.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.27.29110/bin/Hostx64/arm/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - not found
-- Found Threads: TRUE  
-- Could NOT find SRTP (missing: SRTP_INCLUDE_DIRS SRTP_LIBRARIES HAVE_SRTP_SRTP_H SRTP_VERSION) 
-- LibSRTP NOT found, compiling WITHOUT media transport
CMake Error at D:/downloads/tools/cmake-3.18.4-windows/cmake-3.18.4-win32-x86/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
  Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
  system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY
  OPENSSL_INCLUDE_DIR)
Call Stack (most recent call first):
  D:/downloads/tools/cmake-3.18.4-windows/cmake-3.18.4-win32-x86/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:458 (_FPHSA_FAILURE_MESSAGE)
  D:/downloads/tools/cmake-3.18.4-windows/cmake-3.18.4-win32-x86/share/cmake-3.18/Modules/FindOpenSSL.cmake:486 (find_package_handle_standard_args)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:536 (_find_package)
  CMakeLists.txt:190 (find_package)


-- Configuring incomplete, errors occurred!
See also "D:/buildtrees/libdatachannel/arm-uwp-rel/CMakeFiles/CMakeOutput.log".
See also "D:/buildtrees/libdatachannel/arm-uwp-rel/CMakeFiles/CMakeError.log".
[2/2] cmd /c "cd ../../arm-uwp-dbg && "D:/downloads/tools/cmake-3.18.4-windows/cmake-3.18.4-win32-x86/bin/cmake.exe" "D:/buildtrees/libdatachannel/src/v0.9.4-4b1512394f.clean" "-DNO_WEBSOCKET=OFF" "-DNO_EXAMPLES=ON" "-DNO_TESTS=ON" "-DCMAKE_SYSTEM_NAME=WindowsStore" "-DCMAKE_SYSTEM_VERSION=10.0" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/a/1/s/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=arm-uwp" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v142" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/a/1/s/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=arm" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/a/1/s" "-D_VCPKG_INSTALLED_DIR=D:/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-AARM" "-G" "Visual Studio 16 2019" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=D:/packages/libdatachannel_arm-uwp/debug""
FAILED: ../../arm-uwp-dbg/CMakeCache.txt 
cmd /c "cd ../../arm-uwp-dbg && "D:/downloads/tools/cmake-3.18.4-windows/cmake-3.18.4-win32-x86/bin/cmake.exe" "D:/buildtrees/libdatachannel/src/v0.9.4-4b1512394f.clean" "-DNO_WEBSOCKET=OFF" "-DNO_EXAMPLES=ON" "-DNO_TESTS=ON" "-DCMAKE_SYSTEM_NAME=WindowsStore" "-DCMAKE_SYSTEM_VERSION=10.0" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/a/1/s/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=arm-uwp" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v142" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/a/1/s/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=arm" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/a/1/s" "-D_VCPKG_INSTALLED_DIR=D:/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-AARM" "-G" "Visual Studio 16 2019" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=D:/packages/libdatachannel_arm-uwp/debug""
-- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.
-- The CXX compiler identification is MSVC 19.27.29111.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.27.29110/bin/Hostx64/arm/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - not found
-- Found Threads: TRUE  
-- Could NOT find SRTP (missing: SRTP_INCLUDE_DIRS SRTP_LIBRARIES HAVE_SRTP_SRTP_H SRTP_VERSION) 
-- LibSRTP NOT found, compiling WITHOUT media transport
CMake Error at D:/downloads/tools/cmake-3.18.4-windows/cmake-3.18.4-win32-x86/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
  Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
  system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY
  OPENSSL_INCLUDE_DIR)
Call Stack (most recent call first):
  D:/downloads/tools/cmake-3.18.4-windows/cmake-3.18.4-win32-x86/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:458 (_FPHSA_FAILURE_MESSAGE)
  D:/downloads/tools/cmake-3.18.4-windows/cmake-3.18.4-win32-x86/share/cmake-3.18/Modules/FindOpenSSL.cmake:486 (find_package_handle_standard_args)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:536 (_find_package)
  CMakeLists.txt:190 (find_package)


-- Configuring incomplete, errors occurred!
See also "D:/buildtrees/libdatachannel/arm-uwp-dbg/CMakeFiles/CMakeOutput.log".
See also "D:/buildtrees/libdatachannel/arm-uwp-dbg/CMakeFiles/CMakeError.log".
ninja: build stopped: subcommand failed.

Nemirtingas · 2020-10-23T19:06:03Z

Thank you very much, I'll take a look.
For SRTP yes, there is no feature variable, the library checks for SRTP, if its available, it will add it by default.
https://github.com/paullouisageneau/libdatachannel/blob/2eb523e2eac2ce646ea66f886925f7516a280add/CMakeLists.txt#L165-L166

Nemirtingas · 2020-10-23T22:43:23Z

This looks promising now.

…f CONTROL file.

ports/libdatachannel/vcpkg.json

…P option.

BillyONeal · 2020-10-25T05:22:27Z

For SRTP yes, there is no feature variable, the library checks for SRTP, if its available, it will add it by default.

I see, that needs to be patched to avoid the auto-detection -- ports should not be substantially different depending on whether other ports are installed, since it affects binary caching. That is, on one system, if someone does:

vcpkg install srtp
vcpkg install libdatachannel[core]

and on another system they do:

vcpkg install libdatachannel[core]
vcpkg install srtp

what they have should be identical, but it isn't if the library in question is doing autodetection.

Why do we have to add extra parameters to use vcpkg.json ?

The "extra parameters" have nothing to do with vcpkg.json, the problem also exists in the CONTROL universe. (All I did to mint that vcpkg.json was vcpkg format-manifest path\to\CONTROL)

Nemirtingas · 2020-10-25T08:12:55Z

I see, that needs to be patched to avoid the auto-detection -- ports should not be substantially different depending on whether other ports are installed, since it affects binary caching.

The libdatachannel maintainer added a flag for SRTP on his latest version. But the latest version also needs latest libjuice. I'll have to update libjuice before merging libdatachannel.
#14213

The "extra parameters" have nothing to do with vcpkg.json, the problem also exists in the CONTROL universe. (All I did to mint that vcpkg.json was vcpkg format-manifest path\to\CONTROL)

I had to set VCPKG_FEATURE_FLAGS=-manifests.

Warning: manifest-root detected at /vcpkg_libdatachannel/ports/libdatachannel, but manifests are not enabled.
If you wish to use manifest mode, you may do one of the following:
    * Add the `manifests` feature flag to the comma-separated environment
      variable `VCPKG_FEATURE_FLAGS`.
    * Add the `manifests` feature flag to the `--feature-flags` option.
    * Pass your manifest directory to the `--x-manifest-root` option.
If you wish to silence this error and use classic mode, you can:
    * Add the `-manifests` feature flag to `VCPKG_FEATURE_FLAGS`.
    * Add the `-manifests` feature flag to `--feature-flags`.

Nemirtingas · 2020-11-16T09:36:45Z

libdatachannel has been updated to v0.10.1 and waiting for the libjuice update.

NancyLi1013 · 2020-11-19T02:08:05Z

/azp run

azure-pipelines · 2020-11-19T02:08:17Z

Azure Pipelines successfully started running 1 pipeline(s).

JackBoosY · 2020-11-20T06:57:53Z

@BillyONeal Do you have any other questions?

strega-nil · 2020-11-23T18:50:44Z

Thanks @Nemirtingas :)

Nemirtingas · 2020-11-23T19:58:19Z

No probs. This library has great potential for webrtc. Google's implementation is too troublesome to setup.

libdatachannel port

48ade4b

JackBoosY assigned LilyWangL Sep 24, 2020

JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 24, 2020

JackBoosY suggested changes Sep 24, 2020

View reviewed changes

ports/libdatachannel/CONTROL Outdated Show resolved Hide resolved

ports/libdatachannel/CONTROL Outdated Show resolved Hide resolved

ports/libdatachannel/usage Outdated Show resolved Hide resolved

ports/libdatachannel/portfile.cmake Outdated Show resolved Hide resolved

Nemirtingas mentioned this pull request Sep 24, 2020

[Discussion] vcpkg port paullouisageneau/libdatachannel#183

Closed

LilyWangL assigned JackBoosY and unassigned LilyWangL Sep 25, 2020

JackBoosY added the requires:author-response label Sep 25, 2020

Fixed various things for pr.

ad8a4d2

Nemirtingas changed the title ~~libdatachannel port~~ [libdatachannel] Add new port Sep 26, 2020

Merge branch 'master' of https://github.com/microsoft/vcpkg into libd…

f17cbb3

…atachannel_port

JackBoosY removed the requires:author-response label Sep 28, 2020

Nemirtingas added 3 commits October 1, 2020 08:10

Update to v0.9.2

53ada4e

Merge branch 'libdatachannel_port' of https://github.com/Nemirtingas/…

9e8b931

…vcpkg into libdatachannel_port

Update to 0.9.4 and enable SRTP feature

2ed77e2

Merge branch 'master' of https://github.com/microsoft/vcpkg into libd…

1d6485d

…atachannel_port

LilyWangL mentioned this pull request Oct 13, 2020

[New Port Request] libdatachannel #13487

Closed

JackBoosY added the requires:author-response label Oct 13, 2020

JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Oct 13, 2020

Merge branch 'master' into libdatachannel_port

71a221a

BillyONeal requested changes Oct 23, 2020

View reviewed changes

BillyONeal added requires:author-response and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Oct 23, 2020

Nemirtingas added 2 commits October 23, 2020 21:37

Add openssl dependency

59e1c5b

Fix usrsctp find_library

9c6c58c

BillyONeal added 2 commits October 23, 2020 18:36

Merge remote-tracking branch 'origin/master' into HEAD

c084b5f

Flip the sense of the websockets feature and use a manifest instead o…

bba6833

…f CONTROL file.

BillyONeal requested changes Oct 24, 2020

View reviewed changes

ports/libdatachannel/vcpkg.json Show resolved Hide resolved

Need to update libjuice and libdatachannel but there is now a USE_SRT…

650e7cb

…P option.

Nemirtingas added 2 commits October 25, 2020 10:10

Update libdatachannel for USE_SRTP Option

d7313ce

Update libdatachannel to v0.10.1

8d16270

JackBoosY requested a review from BillyONeal November 20, 2020 06:57

JackBoosY removed the requires:author-response label Nov 20, 2020

strega-nil merged commit 9555c11 into microsoft:master Nov 23, 2020

Nemirtingas deleted the libdatachannel_port branch February 24, 2021 18:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[libdatachannel] Add new port #13704

[libdatachannel] Add new port #13704

Nemirtingas commented Sep 24, 2020 •

edited

Nemirtingas commented Sep 25, 2020

ras0219-msft commented Sep 28, 2020

azure-pipelines bot commented Sep 28, 2020

Nemirtingas commented Oct 1, 2020

JackBoosY commented Oct 9, 2020

azure-pipelines bot commented Oct 9, 2020

JackBoosY commented Oct 10, 2020

BillyONeal commented Oct 12, 2020

JackBoosY commented Oct 13, 2020

Nemirtingas commented Oct 13, 2020

Nemirtingas commented Oct 23, 2020

Nemirtingas commented Oct 23, 2020

BillyONeal left a comment

Nemirtingas commented Oct 23, 2020 •

edited

Nemirtingas commented Oct 23, 2020

BillyONeal commented Oct 25, 2020

Nemirtingas commented Oct 25, 2020 •

edited

Nemirtingas commented Nov 16, 2020

NancyLi1013 commented Nov 19, 2020

azure-pipelines bot commented Nov 19, 2020

JackBoosY commented Nov 20, 2020

strega-nil commented Nov 23, 2020

Nemirtingas commented Nov 23, 2020

[libdatachannel] Add new port #13704

[libdatachannel] Add new port #13704

Conversation

Nemirtingas commented Sep 24, 2020 • edited

Nemirtingas commented Sep 25, 2020

ras0219-msft commented Sep 28, 2020

azure-pipelines bot commented Sep 28, 2020

Nemirtingas commented Oct 1, 2020

JackBoosY commented Oct 9, 2020

azure-pipelines bot commented Oct 9, 2020

JackBoosY commented Oct 10, 2020

BillyONeal commented Oct 12, 2020

JackBoosY commented Oct 13, 2020

Nemirtingas commented Oct 13, 2020

Nemirtingas commented Oct 23, 2020

Nemirtingas commented Oct 23, 2020

BillyONeal left a comment

Choose a reason for hiding this comment

Nemirtingas commented Oct 23, 2020 • edited

Nemirtingas commented Oct 23, 2020

BillyONeal commented Oct 25, 2020

Nemirtingas commented Oct 25, 2020 • edited

Nemirtingas commented Nov 16, 2020

NancyLi1013 commented Nov 19, 2020

azure-pipelines bot commented Nov 19, 2020

JackBoosY commented Nov 20, 2020

strega-nil commented Nov 23, 2020

Nemirtingas commented Nov 23, 2020

Nemirtingas commented Sep 24, 2020 •

edited

Nemirtingas commented Oct 23, 2020 •

edited

Nemirtingas commented Oct 25, 2020 •

edited