Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg_common_definitions] Add macro VCPKG_HOST_IS_<target> #13730

Merged
merged 4 commits into from
Oct 17, 2020
Merged

[vcpkg_common_definitions] Add macro VCPKG_HOST_IS_<target> #13730

merged 4 commits into from
Oct 17, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Sep 25, 2020 •
edited
Loading

Provide host architecture macros to the cross-platform compilation environment instead of CMAKE_HOST_WIN32 etc.

  • VCPKG_HOST_IS_WINDOWS
  • VCPKG_HOST_IS_OSX
  • VCPKG_HOST_IS_LINUX
  • VCPKG_HOST_IS_DARWIN

Related: #10913.

@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. labels Sep 25, 2020
PhoebeHui
PhoebeHui approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JackBoosY
Copy link
Contributor Author

blocked by #13765.

@ras0219-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Oct 9, 2020
@dan-shaw dan-shaw added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Oct 14, 2020
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Oct 16, 2020
@dan-shaw dan-shaw merged commit b69056b into microsoft:master Oct 17, 2020
@JackBoosY JackBoosY deleted the dev/jack/vcpkg_host_is_target branch October 19, 2020 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@dan-shaw dan-shaw dan-shaw approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@PhoebeHui PhoebeHui

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JackBoosY @ras0219-msft @BillyONeal @PhoebeHui @dan-shaw