Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eigen3] Fix include path #13739

Merged
merged 5 commits into from Nov 6, 2020
Merged

[eigen3] Fix include path #13739

merged 5 commits into from Nov 6, 2020

Conversation

LilyWangL
Copy link
Contributor

Describe the pull request

@LilyWangL LilyWangL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Sep 25, 2020
@LilyWangL LilyWangL mentioned this pull request Oct 21, 2020
Closed
@LilyWangL LilyWangL marked this pull request as ready for review October 21, 2020 03:11
@petrasvestartas
Copy link

petrasvestartas commented Oct 21, 2020 •
edited

@LilyWangL

I can confirm that this issue persists for other users.
I tried to follow the other issues you reference, but I do not understand the workaround.

Could explain how to reference Eigen for PCL?

image

@PhoebeHui PhoebeHui marked this pull request as draft October 22, 2020 07:31
@LilyWangL LilyWangL marked this pull request as ready for review November 4, 2020 08:13
@LilyWangL
Copy link
Contributor Author

@LilyWangL

I can confirm that this issue persists for other users.
I tried to follow the other issues you reference, but I do not understand the workaround.

Could explain how to reference Eigen for PCL?

image

Sorry I am late. You can modify your [VCPKG_path]/ports/eigen3/portfile.cmake according to my change and rebuild eigen3. Then I think you can rebuild your project successfully.

@LilyWangL
Copy link
Contributor Author

Baseline error will be fixed in PR #14400

@BillyONeal BillyONeal merged commit f754a36 into microsoft:master Nov 6, 2020
@BillyONeal
Copy link
Member

Thanks for your help!

@LilyWangLL LilyWangLL mentioned this pull request Jun 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[eigen3] installs headers in the wrong place since recent merge
4 participants
@LilyWangL @petrasvestartas @BillyONeal @PhoebeHui