[rbdl] Add new port

[RDCH106]

RBDL - Rigid Body Dynamics Library

• What does your PR fix?

  • This PR adds a new port for the RDBL for Windows and Linux. It builds the library downloading it from official repository and making compilation through CMake according to Packaging Zipfiles guide.

  • The port only builds the core library and not the optional addons (future work for features).

  • Port was tested in vcpkg 2020.07 with RBDL 2.6.0

• Which triplets are supported/not supported?

  • Expected supported triplets: Triplets tested by CI baseline

• Have you updated the CI baseline?

  • Not updated the CI baseline.

• Does your PR follow the maintainer guide?

  • All the implementation has been done taking into account the Maintainer Guidelines and Policies.

[ghost]

All CLA requirements met.

[RDCH106]

I am going to update Supports field. It works perfectly for Windows and I am using on Windows.
Linux and OSX remains as future work. ok?

[RDCH106]

I don't understand... 🤔

The previous build was: https://dev.azure.com/vcpkg/public/_build/results?buildId=43808&view=logs&j=d3670d0c-cc82-50c9-762c-eccde036829f

And the new one: https://dev.azure.com/vcpkg/public/_build/results?buildId=43818&view=logs&j=a83b7983-e539-5449-9e09-337ff5f52283

• Between 2 builds starts failing x86-windows when in the previous one was marked as success
• I exclude linux and osx in Supports field and using vcpkg_fail_port_install... they continue failing in CI

@NancyLi1013 any idea or recommendation about that?

Thanks in advance.

[NancyLi1013]

Hi @RDCH106
I checked the build results here https://dev.azure.com/vcpkg/public/_build/results?buildId=43808&view=logs&j=d3670d0c-cc82-50c9-762c-eccde036829f and found that:

The failures on Linux and osx are due to this:

c++: error: /bigobj: No such file or directory

Since /bigobj is only used in MSVC.

The failures on uwp are due to this:

CMake Error at ports/rbdl/portfile.cmake:29 (file):
  file COPY cannot find "D:/buildtrees/rbdl/x64-uwp-dbg/rbdl.dll": No error.
Call Stack (most recent call first):
  scripts/ports.cmake:79 (include)

Generally, CMake will install the targets to the related directory automatically and we don't need to handle it manually.
So this part might not be needed.

if(VCPKG_LIBRARY_LINKAGE STREQUAL dynamic)
    if(VCPKG_TARGET_IS_WINDOWS)
        if(NOT DEFINED VCPKG_BUILD_TYPE OR VCPKG_BUILD_TYPE STREQUAL "debug")
            file(COPY ${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-dbg/rbdl.dll DESTINATION ${CURRENT_PACKAGES_DIR}/debug/bin)
        endif()
        if(NOT DEFINED VCPKG_BUILD_TYPE OR VCPKG_BUILD_TYPE STREQUAL "release")
            file(COPY ${CURRENT_BUILDTREES_DIR}/${TARGET_TRIPLET}-rel/rbdl.dll DESTINATION ${CURRENT_PACKAGES_DIR}/bin)
        endif()
    endif()
endif()

You can make a patch to add
RUNTIME DESTINATION ${CMAKE_INSTALL_LIBDIR} to install targets in dynamic build.

Based on the above situation, I think this port supports all platform. So we can remove Supports field now and try to fix the failures and rebuild this.

Note: You can merge the master branch to this PR when you do the changes.

[RDCH106]

Just one more question to be more self-reliant next time. The error due /bigobj only supported by MSVC is not showed here: https://dev.azure.com/vcpkg/public/_build/results?buildId=43808&view=logs&j=d3670d0c-cc82-50c9-762c-eccde036829f

But how can I inspect /mnt/vcpkg-ci/buildtrees/rbdl/install-x64-linux-dbg-out.log? Is it any way to access the log produced by the CI to see that file?

Thanks in advance and sorry for my many questions

[RDCH106]

@NancyLi1013 removing Supports field and vcpkg_fail_port_install function produces global failure. It have no sense for me...

[RDCH106]

I begin to understand... The successfully builds are because they are skipping CMake building 😅, but I don't know how to resolve it because have no idea how to see CMake logs in Azure DevOps.

[NancyLi1013]

Hi @RDCH106

The failures are caused by the patch. It seems you didn't update the patch. So It failed to apply.

CMake Error at scripts/cmake/vcpkg_apply_patches.cmake:54 (message):
  Applying patch failed.  error: corrupt patch at line 16

Call Stack (most recent call first):
  scripts/cmake/vcpkg_extract_source_archive_ex.cmake:141 (vcpkg_apply_patches)
  scripts/cmake/vcpkg_from_github.cmake:139 (vcpkg_extract_source_archive_ex)
  ports/rbdl/portfile.cmake:7 (vcpkg_from_github)
  scripts/ports.cmake:79 (include)

You need to make a new patch.

[NancyLi1013]

You can check the results here https://dev.azure.com/vcpkg/public/_build/results?buildId=43865&view=logs&j=5dffab7c-3299-5a76-7b02-e037cd868fad&t=1294d155-2ef8-5412-c4b1-d5b95781dd72&l=1574.

Other triplets are the same as this.

[RDCH106]

I think it's ready 😁

@NancyLi1013, thank you again for your huge job and patient with me.

[NancyLi1013]

Thanks for your efforts to this PR. @RDCH106
LGTM now.