Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[osg] Fix feature plugin #13942

Merged

Conversation

JackBoosY
Copy link
Contributor

When building osg[plugin]:

installed\x86-windows\include\Inventor/system/gl-headers.h(50,10): fatal error C1083: Cannot open include file: 'GL/glext.h': No such file or directory (compiling source file D:\buildtrees\osg\src\raph-3.6.5-4fd22a77bc.clean\src\osgPlugins\Inventor\ConvertFromInventor.cpp) [D:\buildtrees\osg\x86-windows-dbg\src\osgPlugins\Inventor\osgdb_iv.vcxproj]

Fix this issue.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Oct 9, 2020
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Oct 9, 2020

coin:Inventor/system/gl-headers.h
There is no dependency between coin and osg, but why it happend?

Edit: Seems use wrong opengl headers:

coin:Inventor/system/gl-headers.h
coin:Inventor/system/gl.h
coin:Inventor/system/inttypes.h

Edit:
In osg\src\CMakeLists.txt line 743:

FIND_PACKAGE(Inventor)

This finds the coin, and the coin needs to use the opengl-registry header file.
In osg\src\osgPlugins\CMakeLists.txt line 158:

IF(NOT OSG_GLES1_AVAILABLE AND NOT OSG_GLES2_AVAILABLE)
    IF(INVENTOR_FOUND)
        ADD_PLUGIN_DIRECTORY(Inventor)
    ENDIF()
ENDIF()

This use coin in the plugin Inventor.

@JackBoosY JackBoosY marked this pull request as ready for review October 10, 2020 03:17
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Oct 10, 2020
Comment on lines +9 to +10
- FIND_PACKAGE(Inventor)
+ FIND_PACKAGE(coin CONFIG)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inventor is a part of coin.

@BillyONeal BillyONeal merged commit 37c412a into microsoft:master Oct 12, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants