Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] translate the README to french #13971

Merged
merged 12 commits into from
Oct 30, 2020
Merged

[vcpkg] translate the README to french #13971

merged 12 commits into from
Oct 30, 2020

Conversation

x0rld
Copy link
Contributor

@x0rld x0rld commented Oct 10, 2020 •
edited
Loading

Describe the pull request
I translated the README to french to help people

@ghost
Copy link

ghost commented Oct 10, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

AntoineJT
AntoineJT suggested changes Oct 11, 2020
View reviewed changes
Copy link

@AntoineJT AntoineJT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some changes : the most of them are typo fixing, other are wording changes to better stick with the english readme, etc.

README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
x0rld
x0rld commented Oct 11, 2020
View reviewed changes
Copy link
Contributor Author

@x0rld x0rld left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's done just some typos to fix

x0rld and others added 3 commits October 11, 2020 03:09
@x0rld @AntoineJT
Apply suggestions from code review
b1f0164 
fix typos

Co-authored-by: Antoine James Tournepiche <26577763+AntoineJT@users.noreply.github.com>
fix the last typo
8f140b1
@x0rld @AntoineJT
Apply suggestions from code review
3cd9306 
some new typo fix

Co-authored-by: Antoine James Tournepiche <26577763+AntoineJT@users.noreply.github.com>
JackBoosY
JackBoosY suggested changes Oct 12, 2020
View reviewed changes
README.md Show resolved Hide resolved
@JackBoosY JackBoosY added the category:documentation To resolve the issue, documentation will need to be updated label Oct 12, 2020
@x0rld @JackBoosY
remove useless blank line
351ddc5 
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
@PhoebeHui PhoebeHui changed the title translate the README to french [vcpkg] translate the README to french Oct 13, 2020
vicroms
vicroms reviewed Oct 25, 2020
View reviewed changes
Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit (comma to period), feel free to disregard since I don't know French.

README_fr.md Outdated Show resolved Hide resolved
@x0rld @vicroms
fix typo
7dfe413 
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
@x0rld x0rld requested a review from JackBoosY October 30, 2020 00:17
Lectem
Lectem reviewed Oct 30, 2020
View reviewed changes
Copy link
Contributor

@Lectem Lectem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks on things that look weird to me as a french person (maybe not to someone from Québec?), but otherwise looks good

README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
README_fr.md Outdated Show resolved Hide resolved
Asharas
Asharas reviewed Oct 30, 2020
View reviewed changes
README_fr.md Outdated Show resolved Hide resolved
@BillyONeal BillyONeal merged commit 72abcc5 into microsoft:master Oct 30, 2020
@BillyONeal
Copy link
Member

Je m'appelle Bill. Merci! ... something something French.

Also thanks to Olivier Giroux who double checked: https://twitter.com/__simt__/status/1322026346256560128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicroms vicroms vicroms left review comments

@Lectem Lectem Lectem left review comments

@Asharas Asharas Asharas left review comments

@AntoineJT AntoineJT AntoineJT requested changes

@JackBoosY JackBoosY Awaiting requested review from JackBoosY

Assignees

@PhoebeHui PhoebeHui

@JackBoosY JackBoosY

Labels
category:documentation To resolve the issue, documentation will need to be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@x0rld @BillyONeal @vicroms @Lectem @AntoineJT @Asharas @JackBoosY @PhoebeHui