Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] preprocess _ignore_flags with vcpkg_escape_regex_control_characters #14018

Merged
merged 2 commits into from Nov 13, 2020
Merged

[vcpkg] preprocess _ignore_flags with vcpkg_escape_regex_control_characters #14018

merged 2 commits into from Nov 13, 2020

Conversation

jgilje
Copy link
Contributor

@jgilje jgilje commented Oct 13, 2020

Describe the pull request

  • What does your PR fix?

Following the work in 299f581, the vcpkg_escape_regex_control_characters should also be called for the _ignore_flags. I have vcpkg in a subdirectory of a directory named c++, and the string-regex-replace at line 172 fails without this.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

NA

Yes

@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Oct 14, 2020
@JackBoosY
Copy link
Contributor

cc @Neumann-A for review this PR.

@PhoebeHui PhoebeHui changed the title preprocess _ignore_flags with vcpkg_escape_regex_control_characters [vcpkg] preprocess _ignore_flags with vcpkg_escape_regex_control_characters Nov 5, 2020
@jgilje
Copy link
Contributor Author

jgilje commented Nov 11, 2020

Hi, just a friendly nod, any progress here? I think the one pending check has been stuck since a few hours after i opened this PR 😃

Also, wanted to add that the sdl2 port at least triggers the bug described here.

@JackBoosY
Copy link
Contributor

Hmm... I'm not sure. @strega-nil what do you think about?

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Nov 13, 2020
@strega-nil strega-nil merged commit 9ee0529 into microsoft:master Nov 13, 2020
@jgilje jgilje deleted the escape_ignore_flags branch November 13, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jgilje @JackBoosY @strega-nil