Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[antlr4] update to 4.8 #14036

Merged
merged 4 commits into from
Oct 17, 2020
Merged

[antlr4] update to 4.8 #14036

merged 4 commits into from
Oct 17, 2020

Conversation

caphosra
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

Fixes #14034.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

This change contains nothing related to triplets or CI.

Yes.

@ghost
Copy link

ghost commented Oct 14, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@LilyWangL LilyWangL added the category:port-update The issue is with a library, which is requesting update new revision label Oct 15, 2020
@LilyWangL
Copy link
Contributor

@capra314cabra Could you fixes old patches? They apply failed when installing new version of antlr4.

@caphosra
Copy link
Contributor Author

@capra314cabra Could you fixes old patches? They apply failed when installing new version of antlr4.

I haven't noticed that. Thanks.
I will make them up to date.

@caphosra
Copy link
Contributor Author

caphosra commented Oct 15, 2020 •
edited
Loading

It has finished successfully reproducing the patch files.

@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Oct 16, 2020
@dan-shaw dan-shaw merged commit 9f2bb70 into microsoft:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangL LilyWangL LilyWangL approved these changes

Assignees

@LilyWangL LilyWangL

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[antlr4] update to 4.8
3 participants
@caphosra @LilyWangL @dan-shaw