[itk,libsamplerate,libsndfile] Apply some Visual Studio 2019 version 16.9 preview 1 workarounds #14056
Conversation
…g lrintf as an intrinsic. Upstream has already fixed this.
Note that the previous erikd/libsndfile is being forwarded by GitHub itself to libsndfile/libsndfile. I checked that the tar.gz for libsamplerate match for the old and new sources.
BillyONeal
added
category:port-bug
| openjpeg.patch | ||
| openjpeg2.patch | ||
| var_libraries.patch | ||
| wrapping.patch | ||
| python_gpu_wrapping.patch | ||
| opencl.patch | ||
| cufftw.patch | ||
| use-the-lrintf-intrinsic.patch |
There was a problem hiding this comment.
Is this the upstream patch? Please add the corresponding PR as a comment
There was a problem hiding this comment.
@Neumann-A No. I went to submit a patch upstream but upstream's master differs enough from the version we're currently installing that it isn't clear whether a patch is necessary there; this one certainly doesn't apply to it.
There was a problem hiding this comment.
still a already patch in <xyz> comment would be good for somebody updating the port to a new version in the future. So that persons knows that it can safely be removed without needing to check if the patch needs adjustment.
There was a problem hiding this comment.
@Neumann-A What I mean is that that isn't the case here. The patched code in master is totally different from the code we're patching in this version, so the patch will need to be reevaluated at such time this version is pushed.
BillyONeal
changed the title
|
|
[libsamplerate,libsndfile] Update sources to libsndfile/ org on GitHub.
Note that the previous erikd/libsndfile is being forwarded by GitHub itself to libsndfile/libsndfile.
I checked that the tar.gz for libsamplerate match for the old and new sources.
[itk] Apply workaround for VS2019 version 16.9 nightly builds defining lrintf as an intrinsic.
Upstream has already fixed this.