[oatpp-sqlite] port added

[KaungZawHtet]

Other oatpp modules hav already been included and this sqlite one left and now here it is

[KaungZawHtet]

After seeing the build failure on UWP , I reported to the main author and he replied. Here is the link:
oatpp/oatpp-sqlite#3 (comment)
As you see, build fail at him too. Please investigate the problem at vcpkg.

[NancyLi1013]

The failures on x64-uwp and arm-uwp:

5>D:\buildtrees\oatpp-sqlite\src\d2e5962be1-146fcc8dbb.clean\src\sqlite\sqlite3.c(42196,56): error C2065: 'AreFileApisANSI': undeclared identifier [D:\buildtrees\oatpp-sqlite\x64-uwp-dbg\src\sqlite.vcxproj]
     5>D:\buildtrees\oatpp-sqlite\src\d2e5962be1-146fcc8dbb.clean\src\sqlite\sqlite3.c(42196,56): warning C4312: 'type cast': conversion from 'int' to 'sqlite3_syscall_ptr' of greater size [D:\buildtrees\oatpp-sqlite\x64-uwp-dbg\src\sqlite.vcxproj]
     5>D:\buildtrees\oatpp-sqlite\src\d2e5962be1-146fcc8dbb.clean\src\sqlite\sqlite3.c(42226,52): error C2065: 'CreateFileA': undeclared identifier [D:\buildtrees\oatpp-sqlite\x64-uwp-dbg\src\sqlite.vcxproj]
     5>D:\buildtrees\oatpp-sqlite\src\d2e5962be1-146fcc8dbb.clean\src\sqlite\sqlite3.c(42226,52): warning C4312: 'type cast': conversion from 'int' to 'sqlite3_syscall_ptr' of greater size [D:\buildtrees\oatpp-sqlite\x64-uwp-dbg\src\sqlite.vcxproj]
     5>D:\buildtrees\oatpp-sqlite\src\d2e5962be1-146fcc8dbb.clean\src\sqlite\sqlite3.c(42235,52): error C2065: 'CreateFileW': undeclared identifier [D:\buildtrees\oatpp-sqlite\x64-uwp-dbg\src\sqlite.vcxproj]
     5>D:\buildtrees\oatpp-sqlite\src\d2e5962be1-146fcc8dbb.clean\src\sqlite\sqlite3.c(42235,52): warning C4312: 'type cast': conversion from 'int' to 'sqlite3_syscall_ptr' of greater size [D:\buildtrees\oatpp-sqlite\x64-uwp-dbg\src\sqlite.vcxproj]
     5>D:\buildtrees\oatpp-sqlite\src\d2e5962be1-146fcc8dbb.clean\src\sqlite\sqlite3.c(42385,52): error C2065: 'GetFileSize': undeclared identifier [D:\buildtrees\oatpp-sqlite\x64-uwp-dbg\src\sqlite.vcxproj]
     5>D:\buildtrees\oatpp-sqlite\src\d2e5962be1-146fcc8dbb.clean\src\sqlite\sqlite3.c(42385,52): warning C4312: 'type cast': conversion from 'int' to 'sqlite3_syscall_ptr' of greater size [D:\buildtrees\oatpp-sqlite\x64-uwp-dbg\src\sqlite.vcxproj]
     5>D:\buildtrees\oatpp-sqlite\src\d2e5962be1-146fcc8dbb.clean\src\sqlite\sqlite3.c(42531,53): error C2065: 'HeapValidate': undeclared identifier [D:\buildtrees\oatpp-sqlite\x64-uwp-dbg\src\sqlite.vcxproj]
     5>D:\buildtrees\oatpp-sqlite\src\d2e5962be1-146fcc8dbb.clean\src\sqlite\sqlite3.c(42531,53): warning C4312: 'type cast': conversion from 'int' to 'sqlite3_syscall_ptr' of greater size [D:\buildtrees\oatpp-sqlite\x64-uwp-dbg\src\sqlite.vcxproj]
     5>D:\buildtrees\oatpp-sqlite\src\d2e5962be1-146fcc8dbb.clean\src\sqlite\sqlite3.c(42548,53): error C2065: 'LoadLibraryA': undeclared identifier [D:\buildtrees\oatpp-sqlite\x64-uwp-dbg\src\sqlite.vcxproj]
     5>D:\buildtrees\oatpp-sqlite\src\d2e5962be1-146fcc8dbb.clean\src\sqlite\sqlite3.c(42548,53): warning C4312: 'type cast': conversion from 'int' to 'sqlite3_syscall_ptr' of greater size [D:\buildtrees\oatpp-sqlite\x64-uwp-dbg\src\sqlite.vcxproj]
     5>D:\buildtrees\oatpp-sqlite\src\d2e5962be1-146fcc8dbb.clean\src\sqlite\sqlite3.c(42557,53): error C2065: 'LoadLibraryW': undeclared identifier 

The error occurred when building sqlite3.c file.

Since sqlite3 has been provided in vcpkg now.
We should depend on sqlite3 in vcpkg to build oatpp-sqlite instead of building the source codes embedded in oatpp-sqlite here https://github.com/oatpp/oatpp-sqlite/tree/master/src/sqlite.

So could you please update this to rebuild this again?

[KaungZawHtet]

fixed but failed. For the failure, is there any informative log that need to shared here ?

[NancyLi1013]

CMake Error at D:/downloads/tools/cmake-3.18.4-windows/cmake-3.18.4-win32-x86/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
  Could NOT find SQLite3 (missing: SQLite3_INCLUDE_DIR SQLite3_LIBRARY)
Call Stack (most recent call first):
  D:/downloads/tools/cmake-3.18.4-windows/cmake-3.18.4-win32-x86/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:458 (_FPHSA_FAILURE_MESSAGE)
  D:/downloads/tools/cmake-3.18.4-windows/cmake-3.18.4-win32-x86/share/cmake-3.18/Modules/FindSQLite3.cmake:52 (find_package_handle_standard_args)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:536 (_find_package)
  CMakeLists.txt:108 (find_package)

Please check the log here
https://dev.azure.com/vcpkg/public/_build/results?buildId=44522&view=artifacts&type=publishedArtifacts

[KaungZawHtet]

Fixed and builds are in success now

[NancyLi1013]

Could you please also bump CONTROL file?

Add Port-Version for all ports except for new port oatpp-sqlite.

[KaungZawHtet]

1.2.0 is only version number main author gives us. No bump version we get to display

[NancyLi1013]

1.2.0 is only version number main author gives us. No bump version we get to display

You're right, the version number is from upstream. But we also need to bump CONTROL file. In this case, we can add Port-Version: 1. Since there are changes in these ports.

Please see this doc https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/control-files.md#port-version

[KaungZawHtet]

Port-Version: 2 to oatpp and other oatpp modules except oatpp-sqlite , right ?

[NancyLi1013]

Port-Version: 2 to oatpp and other oatpp modules except oatpp-sqlite , right ?

All Port-Version: should be 1, except oatpp-sqlite.

[BillyONeal]

Thanks again!