Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[abseil] Revert changes about arm build #14109

Merged
merged 10 commits into from Nov 4, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Oct 19, 2020

Correct PR #11827, fix build on arm64-uwp.
Since the arm32 build issue is an upstream bug, revert the modification about it.

Tested arm-windows, arm64-windows, arm-uwp, arm64-uwp, x86-uwp and x64-uwp.

Fixes #13929.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Oct 19, 2020
@@ -8,7 +8,6 @@ set(ABSEIL_PATCHES
# This patch is an upstream commit, the related PR: https://github.com/abseil/abseil-cpp/pull/637
fix-MSVCbuildfail.patch

# Remove this patch in next update, see https://github.com/google/cctz/pull/145
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may still be problems with this official patch. I have opened an issue (google/cctz#173) upstream to discuss this changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering they don't support x86 either it seems unlikely to me that they will care about supporting arm

@BillyONeal
Copy link
Member

I don't think this change is correct: it "fixes" the build by removing the /alternatename but upstream comments indicate the alternatename is necessary for customers. The right fix probably involves authoring an /alternatename with the right name mangling for arm64.

@BillyONeal
Copy link
Member

I/we should try to update absl to see if they already have these patches fixed, then I think we should outright remove those associated patches.

@JackBoosY
Copy link
Contributor Author

@BillyONeal Trying...

@JackBoosY
Copy link
Contributor Author

No, the latest also breaks 32 bit arm build.

@JackBoosY JackBoosY changed the title [abseil] Re-fix arm/uwp build [abseil] Update and re-fix arm/uwp build Oct 23, 2020
@BillyONeal
Copy link
Member

@JackBoosY It breaks arm32 but my argument is that the arm32 build was never correct. It builds successfully only because our old patch is breaking this "alternatename" bit -- not emitting an "alternatename" at all. So the linker doesn't look for the nonexistent symbol so the build succeeds, but the resulting library, which presumably depends on that "alternatename" for users is broken. (And likely nobody noticed because we have relatively few customers who would try to use the resulting library on ARM)

I think we should avoid trying to patch in features like this when it's an upstream lack of support that depends on such a fragile patch.

@JackBoosY JackBoosY changed the title [abseil] Update and re-fix arm/uwp build [abseil] Revert changes about arm build Oct 27, 2020
@JackBoosY
Copy link
Contributor Author

I opened an upstream issue: abseil/abseil-cpp#829

@JackBoosY
Copy link
Contributor Author

When merging this PR, #11820 should be opened again.

ports/abseil/vcpkg.json Outdated Show resolved Hide resolved
@JackBoosY
Copy link
Contributor Author

@BillyONeal Done.

ports/abseil/vcpkg.json Outdated Show resolved Hide resolved
ports/abseil/vcpkg.json Outdated Show resolved Hide resolved
ports/abseil/vcpkg.json Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Nov 4, 2020
ports/abseil/vcpkg.json Outdated Show resolved Hide resolved
JackBoosY and others added 2 commits November 3, 2020 22:11
Co-authored-by: Billy O'Neal <bion@microsoft.com>
Co-authored-by: Billy O'Neal <bion@microsoft.com>
@BillyONeal BillyONeal merged commit 75e24fa into microsoft:master Nov 4, 2020
@BillyONeal
Copy link
Member

Thanks :D

@JackBoosY JackBoosY deleted the dev/jack/13929 branch November 4, 2020 06:50
x-projs pushed a commit to x-projs/vcpkg that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[abseil:arm64-uwp] build failure
3 participants