Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libnice] Fix build error on Linux #14248

Merged
merged 6 commits into from Nov 6, 2020
Merged

[libnice] Fix build error on Linux #14248

merged 6 commits into from Nov 6, 2020

Conversation

LilyWangL
Copy link
Contributor

Describe the pull request

@LilyWangL LilyWangL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Oct 27, 2020
@LilyWangL LilyWangL marked this pull request as ready for review October 28, 2020 02:16
JackBoosY
JackBoosY suggested changes Nov 4, 2020
View reviewed changes
ports/libnice/CMakeLists.txt Outdated Show resolved Hide resolved
ports/libnice/CMakeLists.txt Outdated Show resolved Hide resolved
ports/libnice/CMakeLists.txt Outdated Show resolved Hide resolved
@LilyWangL
Copy link
Contributor Author

Baseline error will be fixed in PR #14400

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Nov 6, 2020
@BillyONeal BillyONeal merged commit 5a95fe2 into microsoft:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libnice] Can't build on something else than Windows
3 participants
@LilyWangL @JackBoosY @BillyONeal