Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] mingw: Add compiler executable name into toolchain file #14269

Merged
merged 1 commit into from
Oct 30, 2020
Merged

[vcpkg] mingw: Add compiler executable name into toolchain file #14269

merged 1 commit into from
Oct 30, 2020

Conversation

longnguyen2004
Copy link
Contributor

Describe the pull request

  • What does your PR fix?
    As CMake doesn't automatically detect gcc when the target is windows-gnu anymore, we have to set CMAKE_C_COMPILER and CMAKE_CXX_COMPILER by ourselves.
  • Which triplets are supported/not supported? Have you updated the CI baseline?
    All mingw triplets
  • Does your PR follow the maintainer guide?
    Yes

@longnguyen2004 longnguyen2004 changed the title mingwAdd compiler executable name into toolchain file mingw: Add compiler executable name into toolchain file Oct 28, 2020
@LilyWangL LilyWangL self-assigned this Oct 28, 2020
@LilyWangL LilyWangL added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Oct 28, 2020
@LilyWangL LilyWangL changed the title mingw: Add compiler executable name into toolchain file [vcpkg] mingw: Add compiler executable name into toolchain file Oct 28, 2020
@LilyWangL
Copy link
Contributor

Baseline error will be fixed in PR #14003.

@LilyWangL LilyWangL added the depends:different-pr This PR or Issue depends on a PR which has been filed label Oct 28, 2020
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Oct 29, 2020
@BillyONeal BillyONeal merged commit 6edef9f into microsoft:master Oct 30, 2020
@BillyONeal
Copy link
Member

Thanks!

@longnguyen2004 longnguyen2004 deleted the mingw-compiler-detection branch October 31, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangL LilyWangL LilyWangL approved these changes

Assignees

@LilyWangL LilyWangL

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@longnguyen2004 @LilyWangL @BillyONeal