Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oatpp] Add new port and vcpkg.json #14341

Merged
merged 26 commits into from Nov 6, 2020
Merged

[oatpp] Add new port and vcpkg.json #14341

merged 26 commits into from Nov 6, 2020

Conversation

mheyman
Copy link
Contributor

@mheyman mheyman commented Nov 1, 2020

This pull moves existing (for a couple days) v1.2 oatpp modules from CONTROL to vcpkg.json manifest files

It also adds some 3 new oatpp v1.2 modules, (mongo, postgresql, and zlib) that were not in vcpkg before.

It supports windows and linux, I hope it supports OSX (we'll see ).

@LilyWangL LilyWangL self-assigned this Nov 2, 2020
@LilyWangL LilyWangL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 3, 2020
@LilyWangL LilyWangL changed the title oatpp v1.2 [oatpp] Add new port and vcpkg.json Nov 3, 2020
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Nov 3, 2020
@mheyman
Copy link
Contributor Author

mheyman commented Nov 4, 2020 via email

@BillyONeal
Copy link
Member

No time yet...but planning on it

On Wed, Nov 4, 2020 at 2:13 AM BillyONeal @.***> wrote: @BillyONeal approved this pull request. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14341 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJT7JYTRAD7T754MUFTP4DSOD5LLANCNFSM4TGREZEQ .

OK, I submitted it on your behalf: oatpp/oatpp-mongo#5

@BillyONeal
Copy link
Member

@mheyman Can you confirm you are OK with the changes in 727eede ?

Note that BUILD_SHARED_LIBS was already set by:

if(VCPKG_LIBRARY_LINKAGE STREQUAL "dynamic")
list(APPEND _csc_OPTIONS -DBUILD_SHARED_LIBS=ON)
elseif(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
list(APPEND _csc_OPTIONS -DBUILD_SHARED_LIBS=OFF)
else()
message(FATAL_ERROR
"Invalid setting for VCPKG_LIBRARY_LINKAGE: \"${VCPKG_LIBRARY_LINKAGE}\". "
"It must be \"static\" or \"dynamic\"")
endif()

@BillyONeal
Copy link
Member

It's been a bit and I haven't heard from @mheyman so I'm merging this with those changes. Please open a followup PR if you have additional requested changes.

Thanks for your contribution!

@BillyONeal BillyONeal merged commit bf7f7a1 into microsoft:master Nov 6, 2020
@mheyman
Copy link
Contributor Author

mheyman commented Nov 6, 2020

Thanks @BillyONeal - I don't usually get much time to play with this stuff during the week :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants