Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sentry-native] Disable warning C5105 #14349

Merged
merged 1 commit into from Nov 5, 2020
Merged

[sentry-native] Disable warning C5105 #14349

merged 1 commit into from Nov 5, 2020

Conversation

LilyWangL
Copy link
Contributor

@LilyWangL LilyWangL commented Nov 2, 2020 •
edited

Describe the pull request

  • What does your PR fix?
    sentry-native build failed on Visual Studio 2019 version 16.8 with the following error, disable warning C5105 to fix this error.
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\winbase.h(9461): error C2220: the following warning is treated as an error
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\winbase.h(9461): warning C5105: macro expansion producing 'defined' has undefined behavior

Upstream issue: getsentry/sentry-native#415

@LilyWangL LilyWangL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 2, 2020
@LilyWangL LilyWangL marked this pull request as ready for review November 3, 2020 01:28
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Nov 3, 2020
@BillyONeal
Copy link
Member

Have we engaged with the upstream developers on this?

@LilyWangL LilyWangL mentioned this pull request Nov 4, 2020
Closed
3 tasks
@LilyWangL
Copy link
Contributor Author

Have we engaged with the upstream developers on this?

Done.

@BillyONeal BillyONeal merged commit 68dae46 into microsoft:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LilyWangL @BillyONeal @PhoebeHui