[tensorflow] Add C port #14392
Merged
[tensorflow] Add C port #14392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se customized bazel config is stored in wrong directory
- add patch to fix debug builds - add patch to fix exports for static linking - really build debug (instead of cloning release) - override bazel build options for debug (work around bazel bug) - bazel doesn't support static libraries: work around by building dynamic library and constructing static linkage commands from build log - Windows .pdb file can't be >4GB even on x64: work around using reduced debug information - Windows doesn't support .lib files >4GB even on x64, so split into multiple libs - vcpkg requires equal amount of libs for debug and release: work around using handcrafted empty dummy libs - fix naming of libs (.dll on Windows and .dylib on macOS)
- adapt patch files to tensorflow code changes - update bazel from v0.25.2 to v3.1 - on Windows use python installed on the host instead of embedded python obtained via vcpkg because embedded python lacks pip, which we need to obtain numpy - on Windows add MSYS2 to the PATH so that bazel tools can access MSYS2 GIT - add support for custom CA certificates when using HTTPS_PROXY
The existing implementation totally screwed up commands if the command's arguments contained semicolons (this is the case, e.g., in the FindPython modules of the cmake distribution).
…tually are use cases for this
incorporate changes from microsoft:master
…-more' as required for find_package(Python3)
Revert "incorporate changes from microsoft:master"
…eading the last real libraries contents over the required number of libraries
…/vcpkg into fix-static-builds-and-more
… python) for Windows as we need numpy
NancyLi1013
removed
the
depends:different-pr
NancyLi1013
suggested changes
Nov 13, 2020
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
NancyLi1013
reviewed
Nov 18, 2020
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
JackBoosY
approved these changes
Nov 19, 2020
JackBoosY
reviewed
Nov 19, 2020
JackBoosY
added
info:reviewed
strega-nil
reviewed
Nov 20, 2020
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
|
@jgehw have you tried out tensorflow at it's latest version on your local machine? |
yes, I verified it on my local machine |
|
Alright, thanks so much @jgehw :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a C port for tensorflow. As large parts are identical to the C++ port [tensorflow-cc], I moved them into a common file.
I suggest to wait with reviewing until #13028 is merged into master, because this PR builds upon #13028, and once #13028 is merged the file diffs of this PR will collapse to just a few simple changes.