Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][rtabmap] Fix dependency issue when build tools #14426

Merged
merged 3 commits into from Nov 6, 2020

Conversation

PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui commented Nov 6, 2020

Related #14290

1.Update to build tools as a feature
2. When build tools, it requires yaml-cpp to build rtabmap-euroc_dataset, add the dependency.

Check all tools in https://github.com/introlab/rtabmap/blob/master/tools/CMakeLists.txt

  • ImagesJoiner and StereoEval tools not installed by the Upstream
  • The rtabmap_gui not built since we disabled QT,
  • OPENCV_NONFREE not found when I installed opencv[nonfree] feature, I didn't find related macro exported. So I think we have coverred all tools here.

Failrues:

- Performing post-build validation
The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets.

    D:/packages/rtabmap_x64-windows/bin/rtabmap-euroc_dataset.exe

The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets.

    D:/packages/rtabmap_x64-windows/debug/bin/rtabmap-euroc_dataset.exe

Found 2 error(s). Please correct the portfile:

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 6, 2020
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This port really needed "with all the other ports installed" testing :(

Someday!

@BillyONeal BillyONeal merged commit 5b2d824 into microsoft:master Nov 6, 2020
@PhoebeHui PhoebeHui deleted the dev/Phoebe/rtabmap_2 branch November 11, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants