Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opencascade] update debug paths in *Targets-debug.cmake #14435

Merged
merged 2 commits into from
Nov 9, 2020
Merged

[opencascade] update debug paths in *Targets-debug.cmake #14435

merged 2 commits into from
Nov 9, 2020

Conversation

socuwn
Copy link
Contributor

@socuwn socuwn commented Nov 6, 2020

When building OpenCASCADE with CMake, the OpenCASCADE*Targets-debug.cmake files needs to be updated in order to match the folder structure vcpkg builds them in.

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Nov 8, 2020
@PhoebeHui PhoebeHui assigned NancyLi1013 and unassigned PhoebeHui Nov 9, 2020
NancyLi1013
NancyLi1013 reviewed Nov 9, 2020
View reviewed changes
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also update the version in CONTROL file?

Update Version: 7.4.0 as the follows:

Version: 7.4.0
Port-Version: 1

NancyLi1013
NancyLi1013 approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also update the version in CONTROL file?

@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your PR @socuwn.

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Nov 9, 2020
@strega-nil strega-nil merged commit 6b935b7 into microsoft:master Nov 9, 2020
@socuwn socuwn deleted the 14410-opencascade_cmake_fail branch November 9, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[opencascade] cmake failure
5 participants
@socuwn @NancyLi1013 @strega-nil @PhoebeHui @JackBoosY