[libjpeg-turbo] Enabled jpeg7 and jpeg8 APIs

[ziriax]

Describe the pull request

• Fixes [libjpeg-turbo] Please enable jpeg7 and jpeg8 APIs #14438

• Supports the same triplets as the existing libjpeg-turbo package

[NancyLi1013]

You should also add Feature field in CONTROL file and use vcpkg_check_features() to handle these two features in portfile.cmake file.

Please refer to these docs

https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/control-files.md
https://github.com/microsoft/vcpkg/blob/master/docs/users/manifests.md
https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/vcpkg_check_features.md

[ziriax]

You should also add Feature field in CONTROL file and use vcpkg_check_features() to handle these two features in portfile.cmake file.

Please refer to these docs

https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/control-files.md
https://github.com/microsoft/vcpkg/blob/master/docs/users/manifests.md
https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/vcpkg_check_features.md

Thanks for the feedback.

I'll do my best, I have zero experience with vcpkg.

I pushed a commit that hopefully improves this.

[NancyLi1013]

The codes that handle features look good.

Have you tested these two features? Can they work fine?

[ziriax]

It seems the CI failed because some resources couldn't be downloaded:

2020-11-12T12:47:52.7611064Z -- Downloading https://gitlab.kitware.com/cmake/cmake/-/raw/ab8bd48352df060c4ead210fe30dc4736646206b/Modules/FindPkgConfig.cmake?inline=false... Failed. Status: 7;"Couldn't connect to server"
2020-11-12T12:47:52.7618928Z CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:182 (message):

2020-11-12T12:57:57.9194247Z -- Downloading https://gitlab.kitware.com//paraview/visitbridge/-/archive/c2605b5c3115bc4869c76a0d8bfdd8939b59f283/visitbridge-c2605b5c3115bc4869c76a0d8bfdd8939b59f283.tar.gz... Failed. Status: 7;"Couldn't connect to server"
2020-11-12T12:57:57.9194940Z CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:182 (message):

Does the CI restart automatically?

[NancyLi1013]

Thanks for your kindly reminder. I will rerun the failed triplets and let's see the new test result.

[NancyLi1013]

All CI checks have passed now.

Sorry for the long delay.

Have you tested these two features? Can they work fine on x86-windows and x64-windows-static?

[ziriax]

All CI checks have passed now.

Sorry for the long delay.

Have you tested these two features? Can they work fine on x86-windows and x64-windows-static?

Thanks for the feedback.

No I haven't tested them yet in depth.

Can I commit tests somewhere in this repos, or should I create another repo for testing these?

[NancyLi1013]

Can I commit tests somewhere in this repos, or should I create another repo for testing these?

You can test them manually on your machine, then update the status here. If you don't have enough time to doing this test, I'll test on my local.

[ziriax]

You can test them manually on your machine, then update the status here. If you don't have enough time to doing this test, I'll test on my local.

I indeed have a lot of other work to do, so I would greatly appreciate it if you would do the tests.

[NancyLi1013]

All features have passed with the following triplets:

• x86-windows
• x64-windows-static

LGTM now, thanks for your PR @ziriax.

[BillyONeal]

Thanks for your contribution!