[comms ] update to the next version #14521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added the no warn as error again
NancyLi1013
added
the
category:port-update
NancyLi1013
reviewed
Nov 12, 2020
There was a problem hiding this comment.
The dependency should not be boost. Actually, it only requires these components.
boost-algorithm
boost-filesystem
boost-program-options
Please refer to this:
https://github.com/commschamp/commsdsl/blob/414d03ca41a01ab17089016e452ffc74e09cca46/doc/BUILD.md#how-to-build
NancyLi1013
approved these changes
Nov 12, 2020
NancyLi1013
added
info:reviewed
|
LGTM now, thanks for your PR @mathisloge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Updates both libraries to the next version.
Fixes the repo of the comms library.
Some patches are not needed anymore since the maintainers have implemented the patches directly into the base repositories
Which triplets are supported/not supported? Have you updated the CI baseline? Only uwp not.
Does your PR follow the maintainer guide? yes