Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[comms-ublox] added new port #14523

Merged
merged 3 commits into from Nov 12, 2020
Merged

[comms-ublox] added new port #14523

merged 3 commits into from Nov 12, 2020

Conversation

mathisloge
Copy link
Contributor

Describe the pull request

  • What does your PR fix?
    Adds the ublox protocol based on the comms project.

https://github.com/commschamp/cc.ublox.generated

  • Which triplets are supported/not supported? Have you updated the CI baseline? header only

  • Does your PR follow the maintainer guide? yes

@mathisloge mathisloge marked this pull request as draft November 11, 2020 13:56
@mathisloge mathisloge marked this pull request as ready for review November 11, 2020 14:07
@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 12, 2020
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Nov 12, 2020
@JackBoosY
Copy link
Contributor

LGTM.

@strega-nil strega-nil merged commit 2f847ce into microsoft:master Nov 12, 2020
@mathisloge mathisloge deleted the comms_ubx branch November 12, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants