Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[harfbuzz] fix icu linkage #14530

Merged
merged 1 commit into from
Nov 12, 2020
Merged

[harfbuzz] fix icu linkage #14530

merged 1 commit into from
Nov 12, 2020

Conversation

Neumann-A
Copy link
Contributor

just fixing the icu linkage in harfbuzz
discovered in #14333 due to CI failing (qt6-)qtbase builds.

This was referenced Nov 11, 2020
Merged
Merged
@NancyLi1013 NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label Nov 12, 2020
@PhoebeHui PhoebeHui added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Nov 12, 2020
PhoebeHui
PhoebeHui approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

All features test passed with x64-windows.

@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Nov 12, 2020
@strega-nil strega-nil merged commit a07107b into microsoft:master Nov 12, 2020
@Neumann-A Neumann-A deleted the harfbuzz_fix_icu_linkage branch November 12, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Neumann-A @PhoebeHui @strega-nil @NancyLi1013