Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libarchive] Fix dependencies, combine patches #14535

Merged
merged 1 commit into from Nov 13, 2020

Conversation

JackBoosY
Copy link
Contributor

  • Add REQUIRED on find_package.
  • Combine all fix dependecy related patches
  • Use OpenSSL::Crypto instead of OPENSSL_CRYPTO_LIBRARY to avoid missing openssl's dependencies.

Fixes #12750.

All features are default.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 12, 2020
@JackBoosY
Copy link
Contributor Author

@winsoft666 Can you test whether this PR works?

Thanks.

@PhoebeHui PhoebeHui changed the title [libarchive] Re-fix dependencies, combine patches [libarchive] Fix dependencies, combine patches Nov 12, 2020
@winsoft666
Copy link
Contributor

@winsoft666 Can you test whether this PR works?

Thanks.

Still compile error.


My vcpkg version:
Vcpkg version: 2020.06.15-nohash

CMD:
vcpkg install libarchive:x86-windows

install-x86-windows-dbg-out.log

@JackBoosY
Copy link
Contributor Author

@winsoft666 Did you merge my changes? Please provide the configure log config-x86-windows-dbg-out.log.

@winsoft666
Copy link
Contributor

@winsoft666 Did you merge my changes? Please provide the configure log config-x86-windows-dbg-out.log.

Sorry, it's my fault. I just forgot to merge.

Now, I has merged your commit, but it still failed.

Vcpkg version: 2020.11.12-nohash

config-x86-windows-out.log
install-x86-windows-dbg-out.log

@winsoft666
Copy link
Contributor

@winsoft666 Did you merge my changes? Please provide the configure log config-x86-windows-dbg-out.log.

@JackBoosY
Copy link
Contributor Author

@winsoft666 Can you please remove openssl-windows and retry again?

@winsoft666
Copy link
Contributor

I have removed openssl:x86-windows and openssl:x86-windows-static.
However it still failed.

config-x86-windows-out.log
install-x86-windows-dbg-out.log
stdout-x86-windows.log

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Nov 13, 2020

-- Found OpenSSL: optimized;D:/sourcecode/vcpkg/installed/x86-windows/lib/libcrypto.lib;debug;C:/OpenSSL-Win32/lib/libcryptod.lib (found version "1.1.1h")  

@winsoft666 Please remove C:/OpenSSL-Win32 and try again.
This issue will be fixed in #14552.

@winsoft666
Copy link
Contributor

-- Found OpenSSL: optimized;D:/sourcecode/vcpkg/installed/x86-windows/lib/libcrypto.lib;debug;C:/OpenSSL-Win32/lib/libcryptod.lib (found version "1.1.1h")  

@winsoft666 Please remove C:/OpenSSL-Win32 and try again.
This issue will fixed in #14552.

Yes, you are right. Now it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libarchive] build failure
4 participants