[vcpkg] initial openbsd (community) support #14549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
added
the
category:vcpkg-feature
strega-nil
suggested changes
Nov 13, 2020
|
@strega-nil Thanks, I'll work through your review. I also forgot to add a patched pkg-config to the PR (They ship a custom pkg-config implementation which lacks the |
|
Please ignore the CI failures, it's not relate to this change, I will rerun the PR after it fixed in baseline. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
strega-nil
approved these changes
Nov 16, 2020
strega-nil
added
info:reviewed
|
|
strega-nil
added
depends:different-pr
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
TorMFinn
reviewed
Nov 20, 2020
strega-nil
force-pushed
the
openbsd_community_support
branch
from
9e387c1
to
b10223c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jgilje thanks so much! |
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* initial openbsd support in vcpkg * after clang-format * hardcoded in the preferred compiler for openbsd in bootstrap scipt (thanks @TorMFinn) * Fetch a patched pkg-config because openbsd pkg-config lacks {fcfiledir} * fixes from review feedback * corrected hash for pkg-config.openbsd * re-added missing endif() * regenerate docs * Update scripts/cmake/vcpkg_configure_meson.cmake Co-authored-by: Nicole Mazzuca <mazzucan@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR adds OpenBSD support for vcpkg. I've tested a couple of packages so far, which compile fine (libpq, botan, brotli, sdl2 with dependencies).The triplet-definition is added in the community folder. The patch consists mostly of a set of defines, I was helped in large part by looking at the previous FreeBSD support.
I've defaulted the port to use clang as the gcc included with OpenBSD is quite old (the last GPL2 release). In vcpkg_configure_make(), I've changed the behaviour when running configure to lookup bash in path first.
Quick instructions (included in the triplet file)
Bootstrap using
CC=/usr/bin/clang CXX=/usr/bin/clang++ ./bootstrap-vcpkg.shUse with
VCPKG_FORCE_SYSTEM_BINARIES=1 ./vcpkg install brotliWhat does your PR fix?
OpenBSD support for vcpkg
Which triplets are supported/not supported? Have you updated the CI baseline?
x64-openbsd
Does your PR follow the maintainer guide?
Yes