[liblzma] use upstream CMakeLists.txt + Add pkgconfig. #14615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
added
category:port-update
NancyLi1013
suggested changes
Nov 18, 2020
|
Seems you forget to remove CMakeLists.txt from |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
approved these changes
Nov 20, 2020
JackBoosY
suggested changes
Nov 20, 2020
JackBoosY
approved these changes
Nov 20, 2020
strega-nil
reviewed
Nov 20, 2020
| _find_package(${ARGS} CONFIG) | ||
| if(NOT TARGET LibLZMA::LibLZMA AND TARGET liblzma::liblzma) | ||
| add_library(LibLZMA::LibLZMA INTERFACE IMPORTED) # Too lazy to fix wrong target usage all over vcpkg. |
|
Awesome, thanks @Neumann-A :) |
vicroms
pushed a commit
that referenced
this pull request
Jan 8, 2021
* Adds patch to fix find lzma after changes to use upstream CMakeLists.txt * Reference Issue: [libzippp] x64-windows build failure after liblzma use upstream CMakeLists.txt + Add pkgconfig. (#14615) #14679 #14679 * Reference Commit: PR [liblzma] use upstream CMakeLists.txt + Add pkgconfig. (#14615) eb895b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets see what will break