Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openvdb] Fix dependency issue and usage issue #14651

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

PhoebeHui
Copy link
Contributor

Fixes #12271

Openvdb provide built in FindOpenVDB.cmake file, add vcpkg-cmake-wrapper.cmake to handle the usage issue in vcpkg
Fix IlmBase, Blosc OpenEXR to use the targets that intalled by vcpkg

All features test pass with x64-windows

Test:
find_package(OpenVDB CONFIG REQUIRED)
target_link_libraries(openvdbtest PRIVATE OpenVDB::openvdb)

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 19, 2020
@PhoebeHui PhoebeHui marked this pull request as ready for review November 20, 2020 01:35
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Nov 20, 2020
@strega-nil strega-nil merged commit a6966c2 into microsoft:master Nov 20, 2020
@strega-nil
Copy link
Contributor

Cool, thanks @PhoebeHui :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openvdb: Could not find a package configuration file
3 participants