Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sqlcipher] Update to 4.4.1 #14677

Merged
merged 3 commits into from Nov 30, 2020
Merged

[sqlcipher] Update to 4.4.1 #14677

merged 3 commits into from Nov 30, 2020

Conversation

SvenPStarFinanz
Copy link
Contributor

Updated sqlcipher to 4.4.1, which itself followed sqlite to 3.33.0.

@NancyLi1013 NancyLi1013 self-assigned this Nov 23, 2020
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 23, 2020
NancyLi1013
NancyLi1013 reviewed Nov 23, 2020
View reviewed changes
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also bump the version in vcpkg.jsonfile?

@SvenPStarFinanz
Copy link
Contributor Author

Oops! Done.

NancyLi1013
NancyLi1013 suggested changes Nov 23, 2020
View reviewed changes
ports/sqlcipher/vcpkg.json Outdated Show resolved Hide resolved
@SvenPStarFinanz @NancyLi1013
Update ports/sqlcipher/vcpkg.json
f928814 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@NancyLi1013
Copy link
Contributor

Have you tested these features? Can they work fine?

@SvenPStarFinanz
Copy link
Contributor Author

I have tested (with sqlitebrowser.org), for me they work.

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Nov 27, 2020
@NancyLi1013
Copy link
Contributor

LGTM now and thanks for your PR @SvenPStarFinanz.

@strega-nil strega-nil merged commit e7a3a4c into microsoft:master Nov 30, 2020
@strega-nil
Copy link
Contributor

Thanks @SvenPStarFinanz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SvenPStarFinanz @NancyLi1013 @strega-nil