Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[toml11] fixes installation #14723

Merged
merged 2 commits into from Nov 25, 2020
Merged

[toml11] fixes installation #14723

merged 2 commits into from Nov 25, 2020

Conversation

fran6co
Copy link
Contributor

@fran6co fran6co commented Nov 23, 2020

No need to build the tests and fixes the CMake integration

@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 23, 2020
Hoikas
Hoikas reviewed Nov 24, 2020
View reviewed changes
ports/toml11/CONTROL Outdated Show resolved Hide resolved
@JackBoosY @Hoikas
Update ports/toml11/CONTROL
3cf930b 
Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Nov 24, 2020
@JackBoosY JackBoosY mentioned this pull request Nov 24, 2020
Closed
@strega-nil
Copy link
Contributor

Thanks @fran6co :)

@strega-nil strega-nil merged commit 2534ea4 into microsoft:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoikas Hoikas Hoikas left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fran6co @strega-nil @Hoikas @JackBoosY @NancyLi1013