New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cudnn] Don't copy debug versions of the lib since they aren't provided #14736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump the port version. See documentation.
@JackBoosY Are we good to merge this and #14683? |
Waiting for the pipeline test results. |
@JackBoosY looks like those binaries are still needed for debug. From CI on Windows on the package:
is this PR still viable? Thoughts on a workaround here? Should this be abandoned? |
@jacobkahn We have a policy coming to allow this: I'm gonna put this on depends:different-pr, and merge it once that PR is merged. Depends on #13998 |
Sounds good — thanks, @strega-nil! |
@jacobkahn could you merge with master and add the |
@strega-nil sure — trying now. |
@jacobkahn the actual policy is |
3f6c0c1
to
fe48c14
Compare
Awesome, thanks @jacobkahn ! |
Don't copy debug versions of
libcudnn
to thedebug
output directory since NVIDIA doesn't provide any cuDNN libraries built in debug mode.See #14683 for first discussion, cc @JackBoosY
Same triplets as before are supported. Tested on
x64-linux
.Yes