Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cudnn] Don't copy debug versions of the lib since they aren't provided #14736

Merged
merged 3 commits into from Nov 30, 2020

Conversation

jacobkahn
Copy link
Contributor

@jacobkahn jacobkahn commented Nov 24, 2020

Don't copy debug versions of libcudnn to the debug output directory since NVIDIA doesn't provide any cuDNN libraries built in debug mode.

See #14683 for first discussion, cc @JackBoosY

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Same triplets as before are supported. Tested on x64-linux.

Yes

Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the port version. See documentation.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels Nov 24, 2020
@JackBoosY JackBoosY self-assigned this Nov 24, 2020
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Nov 24, 2020
@jacobkahn
Copy link
Contributor Author

jacobkahn commented Nov 25, 2020

@JackBoosY Are we good to merge this and #14683?

@JackBoosY
Copy link
Contributor

Waiting for the pipeline test results.

@jacobkahn
Copy link
Contributor Author

jacobkahn commented Nov 25, 2020

@JackBoosY looks like those binaries are still needed for debug. From CI on Windows on the package:

Mismatching number of debug and release binaries. Found 0 for debug but 1 for release.
Debug binaries


Release binaries

    D:/packages/cudnn_x64-windows/lib/cudnn.lib

Debug binaries were not found

Mismatching number of debug and release binaries. Found 0 for debug but 1 for release.
Debug binaries


Release binaries

    D:/packages/cudnn_x64-windows/bin/cudnn64_7.dll

Debug binaries were not found

is this PR still viable? Thoughts on a workaround here? Should this be abandoned?

@strega-nil
Copy link
Contributor

strega-nil commented Nov 25, 2020

@jacobkahn We have a policy coming to allow this: VCPKG_POLICY_ALLOW_MISMATCHED_NUMBERS_OF_LIBS (or something along those lines). We don't have it implemented yet tho, it's tied to LLVM 11.

I'm gonna put this on depends:different-pr, and merge it once that PR is merged.

Depends on #13998

@strega-nil strega-nil added the depends:different-pr This PR or Issue depends on a PR which has been filed label Nov 25, 2020
@jacobkahn
Copy link
Contributor Author

Sounds good — thanks, @strega-nil!

@strega-nil
Copy link
Contributor

@jacobkahn could you merge with master and add the VCPKG_POLICY_ALLOW_MISMATCHED_NUMBERS_OF_LIBS?

@jacobkahn
Copy link
Contributor Author

jacobkahn commented Nov 30, 2020

@strega-nil sure — trying now.

@strega-nil
Copy link
Contributor

@jacobkahn the actual policy is VCPKG_POLICY_MISMATCHED_NUMBER_OF_BINARIES

@strega-nil strega-nil merged commit 51f295a into microsoft:master Nov 30, 2020
@strega-nil
Copy link
Contributor

Awesome, thanks @jacobkahn !

@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants