New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[poco] Fix dependency libmariadb #14763
Conversation
@yuntong613 Can you please test this PR? Thanks. |
@yuntong613 Did you pull my changes? |
Build error clear. There is another link error when use libmariadb in poco. In the file Poco/Data/MySQL/MySQL.h ,Line 57, poco link libmysql Automatically, On VS2017 will compile an error —— libmysql.lib not found,it seems need a patch when poco use libmariadb |
Yes,I did poll. The error was happened on using poco library in my program. vcpkg auto link PocoData,PocoDataMySQL ,and poco will auto link libmysql.lib, not libmariadb.lib. |
@yuntong613 Most dependencies are hard code in it's source files. Will fix today. |
@yuntong613 Can you pull and test again? |
I have tried the file changes. |
Thanks @JackBoosY! |
INTERFACE_INCLUDE_DIRECTORIES
in libmariadbENABLE_DATA_MYSQL
Fixes #14713.