Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[poco] Fix dependency libmariadb #14763

Merged
merged 2 commits into from Nov 30, 2020
Merged

Conversation

JackBoosY
Copy link
Contributor

  • Export INTERFACE_INCLUDE_DIRECTORIES in libmariadb
  • Fix using libmariadb on option ENABLE_DATA_MYSQL

Fixes #14713.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 25, 2020
@JackBoosY
Copy link
Contributor Author

@yuntong613 Can you please test this PR?

Thanks.

@JackBoosY
Copy link
Contributor Author

@yuntong613 Did you pull my changes?

@yuntong613
Copy link

Build error clear.

There is another link error when use libmariadb in poco.

In the file Poco/Data/MySQL/MySQL.h ,Line 57, poco link libmysql Automatically, On VS2017 will compile an error —— libmysql.lib not found,it seems need a patch when poco use libmariadb
//
// Automatically link Data library.
//
#if defined(_MSC_VER) && !defined(POCO_NO_AUTOMATIC_LIBS)
#if !defined(MySQL_EXPORTS)
#pragma comment(lib, "PocoDataMySQL" POCO_LIB_SUFFIX)
#endif
#pragma comment(lib, "libmysql")
#endif

@yuntong613
Copy link

Yes,I did poll. The error was happened on using poco library in my program. vcpkg auto link PocoData,PocoDataMySQL ,and poco will auto link libmysql.lib, not libmariadb.lib.
In file poco source code — poco/data/mysql/mysql.h

@JackBoosY
Copy link
Contributor Author

@yuntong613 Most dependencies are hard code in it's source files. Will fix today.

@JackBoosY
Copy link
Contributor Author

@yuntong613 Can you pull and test again?

@yuntong613
Copy link

I have tried the file changes.
Windows and Linux would build well, and be easy to use.
thank you.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Nov 27, 2020
@strega-nil strega-nil merged commit d7c3b9e into microsoft:master Nov 30, 2020
@strega-nil
Copy link
Contributor

Thanks @JackBoosY!

@JackBoosY JackBoosY deleted the dev/jack/14713 branch December 1, 2020 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[poco:libmariadb] build dependency missing
4 participants