Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Fix issue in vcpkg.targets that introduced in 13755 #14797

Merged
merged 1 commit into from Nov 30, 2020

Conversation

PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui commented Nov 26, 2020

Fixes #14729

Fix issue:
When 'Use vcpkg' set to No, the vcpkg tab disappear, user can't enable it again. That due the PropertyGroup condition, which is wrong for the VcpkgPageSchema.

Test with latest vcpkg and vs16.8.2

@PhoebeHui PhoebeHui added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team. labels Nov 26, 2020
Copy link

@ZhilkinSerg ZhilkinSerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@strega-nil strega-nil merged commit 480ec85 into microsoft:master Nov 30, 2020
@PhoebeHui PhoebeHui deleted the dev/Phoebe/buildsystems branch December 23, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do I add vcpkg to Visual Studio 2019
4 participants